Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1346653004: Fix some typos in gn's documentation for "copy". (Closed)

Created:
5 years, 3 months ago by eroman
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, nodir, Bons
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some typos in gn's documentation for "copy". Committed: https://crrev.com/c5166a2201bcf4b8738dcbae33709de0831cabc8 Cr-Commit-Position: refs/heads/master@{#349218}

Patch Set 1 #

Patch Set 2 : Rerun "gn help --markdown all > tools/gn/docs/reference.md" #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M tools/gn/docs/reference.md View 1 3 chunks +24 lines, -5 lines 1 comment Download
M tools/gn/functions_target.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
eroman
5 years, 3 months ago (2015-09-15 17:38:38 UTC) #2
eroman
https://codereview.chromium.org/1346653004/diff/20001/tools/gn/docs/reference.md File tools/gn/docs/reference.md (right): https://codereview.chromium.org/1346653004/diff/20001/tools/gn/docs/reference.md#newcode3783 tools/gn/docs/reference.md:3783: ### **Ordering of flags and values**: Not sure why ...
5 years, 3 months ago (2015-09-15 17:57:26 UTC) #3
brettw
lgtm
5 years, 3 months ago (2015-09-16 20:24:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346653004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346653004/20001
5 years, 3 months ago (2015-09-16 20:32:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 20:48:47 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 20:49:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5166a2201bcf4b8738dcbae33709de0831cabc8
Cr-Commit-Position: refs/heads/master@{#349218}

Powered by Google App Engine
This is Rietveld 408576698