Issue 134663006: Update WTF classes to use OVERRIDE / FINAL when needed

Issue 134663006: Update WTF classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
tkent, eseidel

CC:
blink-reviews, yurys+blink_chromium.org, loislo+blink_chromium.org, adamk+blink_chromium.org, Inactive, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Update WTF classes to use OVERRIDE / FINAL when needed Update WTF classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=eseidel, tkent BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164927

Patch Set 1 #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+95 lines, -95 lines)			Patch
M	Source/wtf/FilePrintStream.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/wtf/Float32Array.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/Float64Array.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/Functional.h	View	29 chunks	+68 lines, -68 lines	0 comments	Download
M	Source/wtf/Int16Array.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/Int32Array.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/Int8Array.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/TypedArrayBase.h	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	Source/wtf/Uint16Array.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/Uint32Array.h	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	Source/wtf/Uint8Array.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/wtf/Uint8ClampedArray.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/text/TextCodecICU.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/wtf/text/TextCodecLatin1.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/wtf/text/TextCodecUTF16.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/wtf/text/TextCodecUTF8.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/wtf/text/TextCodecUserDefined.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/134663006/diff/1/Source/wtf/TypedArrayBase.h File Source/wtf/TypedArrayBase.h (right): https://codereview.chromium.org/134663006/diff/1/Source/wtf/TypedArrayBase.h#newcode140 Source/wtf/TypedArrayBase.h:140: virtual void neuter() OVERRIDE FINAL Very strange choice ...

6 years, 11 months ago (2014-01-11 02:38:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/134663006/1

6 years, 11 months ago (2014-01-11 02:39:02 UTC) #3

Message was sent while issue was closed.

Change committed as 164927

Expand Messages | Collapse Messages