Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 134663003: Add CONTRIBUTING file (Closed)

Created:
6 years, 11 months ago by borenet
Modified:
6 years, 11 months ago
Reviewers:
jcgregorio, hcm, reed1
CC:
skia-review_googlegroups.com, iannucci
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add CONTRIBUTING file This will help to direct those who stumble upon the new github mirror to the proper channels for contributing code. BUG= R=jcgregorio@google.com Committed: https://code.google.com/p/skia/source/detail?r=13044

Patch Set 1 #

Patch Set 2 : Retry upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A CONTRIBUTING View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
borenet
I didn't really know what to put in here, so I'm open to suggestions. Adding ...
6 years, 11 months ago (2014-01-10 22:05:40 UTC) #1
hcm
On 2014/01/10 22:05:40, borenet wrote: > I didn't really know what to put in here, ...
6 years, 11 months ago (2014-01-11 05:50:02 UTC) #2
jcgregorio
Should this be CONTRIBUTING.md so that the URL shows up as a link?
6 years, 11 months ago (2014-01-13 13:30:26 UTC) #3
borenet
On 2014/01/13 13:30:26, jcgregorio wrote: > Should this be CONTRIBUTING.md so that the URL shows ...
6 years, 11 months ago (2014-01-13 14:01:43 UTC) #4
jcgregorio
On 2014/01/13 14:01:43, borenet wrote: > On 2014/01/13 13:30:26, jcgregorio wrote: > > Should this ...
6 years, 11 months ago (2014-01-13 14:04:58 UTC) #5
borenet
On 2014/01/13 14:04:58, jcgregorio wrote: > On 2014/01/13 14:01:43, borenet wrote: > > On 2014/01/13 ...
6 years, 11 months ago (2014-01-13 14:07:12 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-13 14:09:48 UTC) #7
jcgregorio
lgtm
6 years, 11 months ago (2014-01-13 14:10:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/134663003/30001
6 years, 11 months ago (2014-01-13 14:11:28 UTC) #9
commit-bot: I haz the power
Can't process patch for file CONTRIBUTING. Filename can't start with 'CON'.
6 years, 11 months ago (2014-01-13 14:11:30 UTC) #10
rmistry
On 2014/01/13 14:11:30, I haz the power (commit-bot) wrote: > Can't process patch for file ...
6 years, 11 months ago (2014-01-13 14:17:23 UTC) #11
rmistry
On 2014/01/13 14:17:23, rmistry wrote: > On 2014/01/13 14:11:30, I haz the power (commit-bot) wrote: ...
6 years, 11 months ago (2014-01-13 14:17:43 UTC) #12
borenet
6 years, 11 months ago (2014-01-13 15:06:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 manually as r13044 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698