Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1346613002: Avoid excessive data copying for ExternalStreamingStream::SetBookmark. (Closed)

Created:
5 years, 3 months ago by vogelheim
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid excessive data copying for ExternalStreamingStream::SetBookmark. BUG=v8:4422 R=jochen@chromium.org LOG=Y Committed: https://crrev.com/1025d34acf37187d1c872eabe5f603b16ffdaa6a Cr-Commit-Position: refs/heads/master@{#30763}

Patch Set 1 #

Patch Set 2 : Make compilers happy (signed/unsigned comparison) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M src/scanner-character-streams.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/scanner-character-streams.cc View 1 5 chunks +31 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vogelheim
5 years, 3 months ago (2015-09-15 12:56:27 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-15 13:00:04 UTC) #2
jochen (gone - plz use gerrit)
is this enough to regain the entire performance?
5 years, 3 months ago (2015-09-15 13:00:24 UTC) #3
vogelheim
On 2015/09/15 13:00:24, jochen wrote: > is this enough to regain the entire performance? Looks ...
5 years, 3 months ago (2015-09-15 13:45:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346613002/20001
5 years, 3 months ago (2015-09-16 11:35:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 11:37:07 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 11:37:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1025d34acf37187d1c872eabe5f603b16ffdaa6a
Cr-Commit-Position: refs/heads/master@{#30763}

Powered by Google App Engine
This is Rietveld 408576698