Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1346573002: Reland VectorICs: ia32 store ics need a virtual register. (Closed)

Created:
5 years, 3 months ago by mvstanton
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland VectorICs: ia32 store ics need a virtual register. (reason for revert/reland: patch incorrectly left --vector-stores flag on, helpfully revealing some gcstress issues to look at, but they don't need to block this CL). Some pretty hacky code was used to carry out the tail-call handler dispatch on ia32 vector stores due to a lack of free registers. It really tanks performance. A better approach is to use a virtual register on the isolate. BUG= TBR=jkummerow@chromium.org, vogelheim@chromium.org Committed: https://crrev.com/1e00bb57a2969e3e428a1d552116752a95c06022 Cr-Commit-Position: refs/heads/master@{#30737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -18 lines) Patch
M src/assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 8 chunks +24 lines, -14 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M src/isolate.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mvstanton
Hi guys, Here is the patch from yesterday, this time without the offending --vector-stores flag ...
5 years, 3 months ago (2015-09-15 09:39:24 UTC) #2
Jakob Kummerow
rubberstamp LGTM
5 years, 3 months ago (2015-09-15 09:48:33 UTC) #3
vogelheim
lgtm (src/snapshot)
5 years, 3 months ago (2015-09-15 09:53:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346573002/1
5 years, 3 months ago (2015-09-15 09:57:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 10:14:18 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 10:14:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e00bb57a2969e3e428a1d552116752a95c06022
Cr-Commit-Position: refs/heads/master@{#30737}

Powered by Google App Engine
This is Rietveld 408576698