Issue 134653005: Don't show the Autohide Shelf menu option when it's unsupported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134653005: Don't show the Autohide Shelf menu option when it's unsupported. (Closed)

Created:
6 years, 11 months ago by zturner

Modified:
6 years, 11 months ago

Reviewers:
Mr4D (OOO till 08-26)

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't show the Autohide Shelf menu option when it's unsupported. BUG=328742 R=skuhne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244253

Patch Set 2 : Don't show the Autohide shelf option when it's unsupported. #

Total comments: 1

Patch Set 3 : Leave only the check for CanUserModifyAutoHideShelfBehavior #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/ui/ash/launcher/launcher_context_menu.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mr4D (OOO till 08-26)

Please address my comment, then lgtm. https://codereview.chromium.org/134653005/diff/40001/chrome/browser/ui/ash/launcher/launcher_context_menu.cc File chrome/browser/ui/ash/launcher/launcher_context_menu.cc (right): https://codereview.chromium.org/134653005/diff/40001/chrome/browser/ui/ash/launcher/launcher_context_menu.cc#newcode175 chrome/browser/ui/ash/launcher/launcher_context_menu.cc:175: ash::SHELF_AUTO_HIDE_BEHAVIOR_NEVER) || Please ...

6 years, 11 months ago (2014-01-10 21:55:34 UTC) #2

zturner

6 years, 11 months ago (2014-01-10 22:01:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r244253 (presubmit successful).