Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1346513002: ozone: gbm: Fix broken DCHECK if !OS_CHROMEOS (Closed)

Created:
5 years, 3 months ago by spang
Modified:
5 years, 3 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: gbm: Fix broken DCHECK if !OS_CHROMEOS This doesn't even compile: ../../base/logging.h:523:23: error: invalid operands to binary expression ('basic_ostream<char, std::char_traits<char> >' and 'gfx::BufferUsage') ss << names << " (" << v1 << " vs. " << v2 << ")"; ~~~~~~~~~~~~~~~~~~~ ^ ~~ BUG=530712 TEST=cast_shell_linux tryjob with gbm enabled by default Committed: https://crrev.com/58abc5a09d52b275fe379813ac5b4180f4de4ef5 Cr-Commit-Position: refs/heads/master@{#348784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
spang
5 years, 3 months ago (2015-09-14 23:42:41 UTC) #2
dnicoara
lgtm
5 years, 3 months ago (2015-09-14 23:44:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346513002/1
5 years, 3 months ago (2015-09-14 23:45:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 00:13:26 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/58abc5a09d52b275fe379813ac5b4180f4de4ef5 Cr-Commit-Position: refs/heads/master@{#348784}
5 years, 3 months ago (2015-09-15 00:14:09 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:39:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58abc5a09d52b275fe379813ac5b4180f4de4ef5
Cr-Commit-Position: refs/heads/master@{#348784}

Powered by Google App Engine
This is Rietveld 408576698