[Interpreter] Avoid shadowing variables in the bytecode graph builder.

[Interpreter] Avoid shadowing variables in the bytecode graph builder.

Reported by Bruce Dawson.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/f71bc57aa5364d25503ebc98108fe0f4ebddba67
Cr-Commit-Position: refs/heads/master@{#30732}

[oth, 2015-09-14 18:56:37]

The CQ bit was checked by oth@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-14 18:56:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346453002/1

[commit-bot: I haz the power, 2015-09-14 18:56:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 18:56:53]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[oth, 2015-09-14 18:59:02]

oth@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[oth, 2015-09-14 18:59:03]

rmcilroy@ PTAL, this removes instances of shadowing that Bruce found on the bots
running /analyze.

[brucedawson, 2015-09-14 19:01:25]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2015-09-14 19:01:25]

It looks like the change should not affect the behavior of
the code but should resolve the variable shadowing warnings/confusion.

So, I am not an owner but lgtm

[rmcilroy, 2015-09-14 19:25:34]

Lgtm.

[oth, 2015-09-15 07:44:57]

oth@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[oth, 2015-09-15 07:44:57]

mstarzinger@chromium.org: PTAL, just a couple of changes to avoid variable
shadowing.

[Michael Starzinger, 2015-09-15 07:58:10]

LGTM.

[Michael Starzinger, 2015-09-15 07:59:29]

mstarzinger@chromium.org changed reviewers:
+ machenbach@google.com

[Michael Starzinger, 2015-09-15 07:59:29]

FWIW, if we really care about this we need a bot and/or presubmit check on the
V8 waterfall. Otherwise this will be a constant back-and-forth between Bruce and
us.

+Michael Achenbach, just FYI.

[Michael Achenbach, 2015-09-15 08:16:49]

There is this heavy-weight builder:
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Windows%20Analyze -
is there some documentation about it? Maybe we can extract a v8-standalone
version and run it on our waterfall.

[oth, 2015-09-15 08:16:58]

The CQ bit was checked by oth@chromium.org

[commit-bot: I haz the power, 2015-09-15 08:17:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346453002/1

[commit-bot: I haz the power, 2015-09-15 08:18:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-15 08:18:42]

Patchset 1 (id:??) landed as
https://crrev.com/f71bc57aa5364d25503ebc98108fe0f4ebddba67
Cr-Commit-Position: refs/heads/master@{#30732}