Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1346453002: [Interpreter] Avoid shadowing variables in the bytecode graph builder. (Closed)

Created:
5 years, 3 months ago by oth
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, brucedawson
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Avoid shadowing variables in the bytecode graph builder. Reported by Bruce Dawson. BUG=v8:4280 LOG=N Committed: https://crrev.com/f71bc57aa5364d25503ebc98108fe0f4ebddba67 Cr-Commit-Position: refs/heads/master@{#30732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346453002/1
5 years, 3 months ago (2015-09-14 18:56:52 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 3 months ago (2015-09-14 18:56:53 UTC) #4
oth
rmcilroy@ PTAL, this removes instances of shadowing that Bruce found on the bots running /analyze.
5 years, 3 months ago (2015-09-14 18:59:03 UTC) #6
brucedawson
It looks like the change should not affect the behavior of the code but should ...
5 years, 3 months ago (2015-09-14 19:01:25 UTC) #8
rmcilroy
Lgtm.
5 years, 3 months ago (2015-09-14 19:25:34 UTC) #9
oth
mstarzinger@chromium.org: PTAL, just a couple of changes to avoid variable shadowing.
5 years, 3 months ago (2015-09-15 07:44:57 UTC) #11
Michael Starzinger
LGTM.
5 years, 3 months ago (2015-09-15 07:58:10 UTC) #12
Michael Starzinger
FWIW, if we really care about this we need a bot and/or presubmit check on ...
5 years, 3 months ago (2015-09-15 07:59:29 UTC) #14
Michael Achenbach
There is this heavy-weight builder: http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Windows%20Analyze - is there some documentation about it? Maybe we ...
5 years, 3 months ago (2015-09-15 08:16:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346453002/1
5 years, 3 months ago (2015-09-15 08:17:06 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 08:18:27 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 08:18:42 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f71bc57aa5364d25503ebc98108fe0f4ebddba67
Cr-Commit-Position: refs/heads/master@{#30732}

Powered by Google App Engine
This is Rietveld 408576698