Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1346443002: [Extensions UI Mac] Use frameAfterAnimation for extension action button opacity (Closed)

Created:
5 years, 3 months ago by Devlin
Modified:
5 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI Mac] Use frameAfterAnimation for extension action button opacity Button opacity for extension actions is set when the container frame changes, but if the button is also animating, we need to use the final frame to determine the proper opacity. BUG=530820 Committed: https://crrev.com/1be03651d5e0ce01407e2863d860b698182ef17f Cr-Commit-Position: refs/heads/master@{#348696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Devlin
Mind taking a quick look, Avi?
5 years, 3 months ago (2015-09-14 19:48:47 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 3 months ago (2015-09-14 19:55:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346443002/1
5 years, 3 months ago (2015-09-14 19:57:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 20:09:12 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1be03651d5e0ce01407e2863d860b698182ef17f Cr-Commit-Position: refs/heads/master@{#348696}
5 years, 3 months ago (2015-09-14 20:09:56 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:36:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1be03651d5e0ce01407e2863d860b698182ef17f
Cr-Commit-Position: refs/heads/master@{#348696}

Powered by Google App Engine
This is Rietveld 408576698