Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 134643028: Make SkFontMgr interface const. (Closed)

Created:
6 years, 10 months ago by mtklein
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : const ALL the things #

Patch Set 3 : maybe const all the rest too #

Patch Set 4 : dw fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -142 lines) Patch
M include/ports/SkFontMgr.h View 1 4 chunks +20 lines, -20 lines 0 comments Download
M src/core/SkFontHost.cpp View 1 3 chunks +20 lines, -20 lines 0 comments Download
M src/fonts/SkFontMgr_fontconfig.cpp View 1 3 chunks +11 lines, -21 lines 0 comments Download
M src/ports/SkFontHost_linux.cpp View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 1 2 6 chunks +14 lines, -22 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M src/ports/SkFontHost_win_dw.cpp View 1 2 3 9 chunks +39 lines, -39 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein
6 years, 10 months ago (2014-02-04 19:03:01 UTC) #1
reed1
Why does it have to be thread-safe? -- none of the calls that might trigger ...
6 years, 10 months ago (2014-02-04 19:08:37 UTC) #2
mtklein
Have a look? I'm being a little optimistic by editing here and trying on trybots, ...
6 years, 10 months ago (2014-02-04 19:54:07 UTC) #3
reed1
appears that the only places we needed 'mutable' were real gosh darn caches, and those ...
6 years, 10 months ago (2014-02-04 20:10:19 UTC) #4
mtklein_C
On 2014/02/04 20:10:19, reed1 wrote: > appears that the only places we needed 'mutable' were ...
6 years, 10 months ago (2014-02-04 20:59:37 UTC) #5
bungeman-skia
If it passes the bots, lgtm.
6 years, 10 months ago (2014-02-04 21:09:34 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 10 months ago (2014-02-04 22:03:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/134643028/90001
6 years, 10 months ago (2014-02-04 22:22:28 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 22:35:05 UTC) #9
Message was sent while issue was closed.
Change committed as 13314

Powered by Google App Engine
This is Rietveld 408576698