Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Issue 134643026: Cleanup: Unify CodeGenerator class across platforms (Closed)

Created:
6 years, 10 months ago by Jakob Kummerow
Modified:
6 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Cleanup: Unify CodeGenerator class across platforms R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19072

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -163 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +0 lines, -41 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/codegen.h View 1 chunk +28 lines, -0 lines 1 comment Download
M src/ia32/codegen-ia32.h View 1 chunk +0 lines, -37 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/ic-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips/codegen-mips.h View 1 chunk +0 lines, -41 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +0 lines, -36 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
6 years, 10 months ago (2014-02-04 13:43:12 UTC) #1
Sven Panne
lgtm https://codereview.chromium.org/134643026/diff/1/src/codegen.h File src/codegen.h (right): https://codereview.chromium.org/134643026/diff/1/src/codegen.h#newcode90 src/codegen.h:90: class CodeGenerator { Hmmm, basically this is now ...
6 years, 10 months ago (2014-02-04 13:51:54 UTC) #2
Jakob Kummerow
6 years, 10 months ago (2014-02-04 13:53:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19072 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698