Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 134643019: Add null check in ChromeClientImpl::postAccessibilityNotification() for SharedWorker refactoring. (Closed)

Created:
6 years, 11 months ago by horo
Modified:
6 years, 11 months ago
Reviewers:
kinuko, adamk
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add null check in ChromeClientImpl::postAccessibilityNotification(). Because AXObjectCache::accessibilityEnabled() always returns true in the shared worker process, ChromeClientImpl::postAccessibilityNotification() is never called in the process. So we don't need to check m_webView->client() now. But we are planing to move SharedWorker to the renderer process. http://crbug.com/327256 ChromeClientImpl::postAccessibilityNotification() will be called in the shared worker's WebFrame when the accessibility feature is enabled. But m_webView->client() is NULL in the shared worker's WebFrame. So we have to check it. BUG=327256 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/web/ChromeClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
horo
kinuko@ Could you please review this?
6 years, 11 months ago (2014-01-17 08:51:31 UTC) #1
kinuko
Looks good/reasonable to me (I'd like to defer to owners)
6 years, 11 months ago (2014-01-17 09:22:08 UTC) #2
horo
jamesr@ Please review this cl.
6 years, 11 months ago (2014-01-17 09:25:06 UTC) #3
horo
adamk@ Can you take a look? We need this tiny change. Thank you.
6 years, 11 months ago (2014-01-22 05:51:43 UTC) #4
adamk
lgtm This seems fine; are there not other places that need added null-checks? From a ...
6 years, 11 months ago (2014-01-22 16:35:34 UTC) #5
horo
Thank you. I think that other methods in which null pointer is not checked are ...
6 years, 11 months ago (2014-01-23 01:00:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/134643019/1
6 years, 11 months ago (2014-01-23 01:53:00 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 03:59:52 UTC) #8
Message was sent while issue was closed.
Change committed as 165606

Powered by Google App Engine
This is Rietveld 408576698