Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 134643011: Move webview and web_accessible_resources manifest handlers to src/extensions (Closed)

Created:
6 years, 11 months ago by James Cook
Modified:
6 years, 11 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move webview and web_accessible_resources manifest handlers to src/extensions This is a mechanical change -- these classes have no Chrome dependencies. This is a step toward moving extension_protocol.h, which is needed for app_shell. BUG=none TEST=compiles, unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -353 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_accessible_resources_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/web_accessible_resources_handler.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/common/extensions/web_accessible_resources_handler.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/common/extensions/webview_handler.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/common/extensions/webview_handler.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M chrome/renderer/extensions/resource_request_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/common_manifest_handlers.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A + extensions/common/manifest_handlers/web_accessible_resources_info.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/common/manifest_handlers/web_accessible_resources_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/common/manifest_handlers/webview_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/webview_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
miket, PTAL. The rename from _handler.h to _info.h is intentional, to follow what we're doing ...
6 years, 11 months ago (2014-01-15 21:45:23 UTC) #1
miket_OOO
lgtm
6 years, 11 months ago (2014-01-15 21:49:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/134643011/1
6 years, 11 months ago (2014-01-15 23:50:35 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 02:38:11 UTC) #4
Message was sent while issue was closed.
Change committed as 245070

Powered by Google App Engine
This is Rietveld 408576698