Add libwebm in third_party.

Add libwebm in third_party.

libwebm will be used by chromoting client to generate WebM stream for
MediaSource API.

BUG=321825
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245139

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245368

[Tom Finegan, 2014-01-14 02:55:29]

The URL change is the only thing that's really important. I believe
git.chromium.org is eventually going to stop working; at least for libwebm.

https://codereview.chromium.org/134643003/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/134643003/diff/40001/DEPS#newcode298
DEPS:298:
"http://git.chromium.org/webm/libwebm.git@5efd6e3c1df766c08294ad19168e71522ee0d808",
https://chromium.googlesource.com/webm/libwebm.git

https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
File third_party/libwebm/libwebm.gyp (right):

https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
third_party/libwebm/libwebm.gyp:16: },  # target opus
s/opus/libwebm/ ?

https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
File third_party/libwebm/libwebm_nacl.gyp (right):

https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
third_party/libwebm/libwebm_nacl.gyp:12: 'target_name': 'libwebm_nacl',
Shouldn't untrusted remain part of the name?

[Sergey Ulanov, 2014-01-14 18:19:06]

https://codereview.chromium.org/134643003/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/134643003/diff/40001/DEPS#newcode298
DEPS:298:
"http://git.chromium.org/webm/libwebm.git@5efd6e3c1df766c08294ad19168e71522ee0d808",
On 2014/01/14 02:55:29, Tom Finegan wrote:
> https://chromium.googlesource.com/webm/libwebm.git

Done. http://www.webmproject.org/code/ still refers to git.chromium.org - does
it need to be updated?

https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
File third_party/libwebm/libwebm.gyp (right):

https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
third_party/libwebm/libwebm.gyp:16: },  # target opus
On 2014/01/14 02:55:29, Tom Finegan wrote:
> s/opus/libwebm/ ?

Done.

https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
File third_party/libwebm/libwebm_nacl.gyp (right):

https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
third_party/libwebm/libwebm_nacl.gyp:12: 'target_name': 'libwebm_nacl',
On 2014/01/14 02:55:29, Tom Finegan wrote:
> Shouldn't untrusted remain part of the name?

I'm using _nacl for all new NaCl targets because _untrusted is not readable.
Existing _untrusted targets will need to be renamed too. modp_b64_untrusted will
be renamed to modp_b64_nacl.

[Tom Finegan, 2014-01-14 18:39:22]

> Done. http://www.webmproject.org/code/ still refers to http://git.chromium.org
- does
> it need to be updated?
> 

Sent an email offline about this: Thanks for pointing it out.

>
https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
> File third_party/libwebm/libwebm.gyp (right):
> 
>
https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
> third_party/libwebm/libwebm.gyp:16: },  # target opus
> On 2014/01/14 02:55:29, Tom Finegan wrote:
> > s/opus/libwebm/ ?
> 
> Done.
> 
>
https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
> File third_party/libwebm/libwebm_nacl.gyp (right):
> 
>
https://codereview.chromium.org/134643003/diff/40001/third_party/libwebm/libw...
> third_party/libwebm/libwebm_nacl.gyp:12: 'target_name': 'libwebm_nacl',
> On 2014/01/14 02:55:29, Tom Finegan wrote:
> > Shouldn't untrusted remain part of the name?
> 
> I'm using _nacl for all new NaCl targets because _untrusted is not readable.
> Existing _untrusted targets will need to be renamed too. modp_b64_untrusted
will
> be renamed to modp_b64_nacl.

sgtm/lgtm

[commit-bot: I haz the power, 2014-01-14 19:30:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/134643003/120001

[commit-bot: I haz the power, 2014-01-14 23:21:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/134643003/120001

[commit-bot: I haz the power, 2014-01-15 02:44:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/134643003/120001

[commit-bot: I haz the power, 2014-01-15 12:55:35]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2014-01-16 03:14:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/134643003/550001

[commit-bot: I haz the power, 2014-01-16 05:28:56]

Change committed as 245139

[commit-bot: I haz the power, 2014-01-16 20:14:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/134643003/800001

[commit-bot: I haz the power, 2014-01-16 20:14:15]

Failed to apply patch for third_party/libwebm/libwebm_nacl.gyp:
While running svn copy third_party/modp_b64/modp_b64_untrusted.gyp
third_party/libwebm/libwebm_nacl.gyp --config-dir
/b/commit-queue/subversion_config --non-interactive --username
commit-bot@chromium.org;
  svn: Path 'third_party/modp_b64/modp_b64_untrusted.gyp' does not exist

Patch:   NR 
third_party/modp_b64/modp_b64_untrusted.gyp->third_party/libwebm/libwebm_nacl.gyp
Index: third_party/libwebm/libwebm_nacl.gyp
diff --git a/third_party/modp_b64/modp_b64_untrusted.gyp
b/third_party/libwebm/libwebm_nacl.gyp
similarity index 50%
copy from third_party/modp_b64/modp_b64_untrusted.gyp
copy to third_party/libwebm/libwebm_nacl.gyp
index
c51ff05be909b0604a5f440997205bb9c7e312c3..adec08f8551ce25f254020ae997e22cd412e2afd
100644
--- a/third_party/modp_b64/modp_b64_untrusted.gyp
+++ b/third_party/libwebm/libwebm_nacl.gyp
@@ -1,30 +1,28 @@
-# Copyright 2013 The Chromium Authors. All rights reserved.
+# Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
+    'libwebm.gypi',
     '../../native_client/build/untrusted.gypi',
   ],
   'targets': [
     {
-      'target_name': 'modp_b64_untrusted',
+      'target_name': 'libwebm_nacl',
       'type': 'none',
       'variables': {
-        'nlib_target': 'libmodp_b64_untrusted.a',
+        'nlib_target': 'libwebm_nacl.a',
         'build_glibc': 0,
-        'build_newlib': 1,
+        'build_newlib': 0,
         'build_pnacl_newlib': 1,
       },
       'dependencies': [
-        '<(DEPTH)/native_client/tools.gyp:prep_toolchain',
+        '../../native_client/tools.gyp:prep_toolchain',
       ],
-      'toolsets': ['host', 'target'],
       'sources': [
-        'modp_b64.cc',
-        'modp_b64.h',
-        'modp_b64_data.h',
+        '<@(libwebm_sources)',
       ],
-    },
-  ],
+    },  # target libwebm_nacl
+  ]
 }

[commit-bot: I haz the power, 2014-01-16 20:18:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/134643003/870001

[commit-bot: I haz the power, 2014-01-16 23:11:23]

Change committed as 245368