Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 134643002: [PPAPI] Add media stream video track example (Closed)

Created:
6 years, 11 months ago by Peng
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[PPAPI] Add media stream video track example BUG=330851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244686

Patch Set 1 : Update #

Total comments: 2

Patch Set 2 : Fix a typo #

Total comments: 2

Patch Set 3 : Fix review issues #

Total comments: 10

Patch Set 4 : Fix review issues #

Patch Set 5 : Fix build issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -203 lines) Patch
A + ppapi/examples/media_stream_video/media_stream_video.cc View 1 2 3 14 chunks +93 lines, -203 lines 0 comments Download
A ppapi/examples/media_stream_video/media_stream_video.html View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Peng
Hi, The media stream video track example. Please take a look. Thanks.
6 years, 11 months ago (2014-01-10 19:29:59 UTC) #1
bbudge
https://codereview.chromium.org/134643002/diff/20001/ppapi/examples/media_stream_video/media_stream_video.html File ppapi/examples/media_stream_video/media_stream_video.html (right): https://codereview.chromium.org/134643002/diff/20001/ppapi/examples/media_stream_video/media_stream_video.html#newcode26 ppapi/examples/media_stream_video/media_stream_video.html:26: var constractions = { not a word: constractions
6 years, 11 months ago (2014-01-10 21:09:28 UTC) #2
Peng
https://codereview.chromium.org/134643002/diff/20001/ppapi/examples/media_stream_video/media_stream_video.html File ppapi/examples/media_stream_video/media_stream_video.html (right): https://codereview.chromium.org/134643002/diff/20001/ppapi/examples/media_stream_video/media_stream_video.html#newcode26 ppapi/examples/media_stream_video/media_stream_video.html:26: var constractions = { On 2014/01/10 21:09:29, bbudge wrote: ...
6 years, 11 months ago (2014-01-10 21:24:51 UTC) #3
bbudge
https://codereview.chromium.org/134643002/diff/70001/ppapi/examples/media_stream_video/media_stream_video.cc File ppapi/examples/media_stream_video/media_stream_video.cc (right): https://codereview.chromium.org/134643002/diff/70001/ppapi/examples/media_stream_video/media_stream_video.cc#newcode337 ppapi/examples/media_stream_video/media_stream_video.cc:337: CreateYUVTextures(); Shouldn't we DeleteTextures for the old ones before ...
6 years, 11 months ago (2014-01-10 21:39:28 UTC) #4
Peng
https://codereview.chromium.org/134643002/diff/70001/ppapi/examples/media_stream_video/media_stream_video.cc File ppapi/examples/media_stream_video/media_stream_video.cc (right): https://codereview.chromium.org/134643002/diff/70001/ppapi/examples/media_stream_video/media_stream_video.cc#newcode337 ppapi/examples/media_stream_video/media_stream_video.cc:337: CreateYUVTextures(); On 2014/01/10 21:39:28, bbudge wrote: > Shouldn't we ...
6 years, 11 months ago (2014-01-10 22:40:24 UTC) #5
bbudge
lgtm
6 years, 11 months ago (2014-01-10 23:03:52 UTC) #6
dmichael (off chromium)
lgtm https://codereview.chromium.org/134643002/diff/120001/ppapi/examples/media_stream_video/media_stream_video.cc File ppapi/examples/media_stream_video/media_stream_video.cc (right): https://codereview.chromium.org/134643002/diff/120001/ppapi/examples/media_stream_video/media_stream_video.cc#newcode35 ppapi/examples/media_stream_video/media_stream_video.cc:35: class MSVDemoModule : public pp::Module { nit: I'd ...
6 years, 11 months ago (2014-01-13 17:44:22 UTC) #7
yzshen1
LGTM with a few nits. Thanks! https://codereview.chromium.org/134643002/diff/120001/ppapi/examples/media_stream_video/media_stream_video.cc File ppapi/examples/media_stream_video/media_stream_video.cc (right): https://codereview.chromium.org/134643002/diff/120001/ppapi/examples/media_stream_video/media_stream_video.cc#newcode375 ppapi/examples/media_stream_video/media_stream_video.cc:375: &MSVDemoInstance::OnGetFrame)); nit: wrong ...
6 years, 11 months ago (2014-01-13 17:57:52 UTC) #8
Peng
Thanks for reviewing. https://codereview.chromium.org/134643002/diff/120001/ppapi/examples/media_stream_video/media_stream_video.cc File ppapi/examples/media_stream_video/media_stream_video.cc (right): https://codereview.chromium.org/134643002/diff/120001/ppapi/examples/media_stream_video/media_stream_video.cc#newcode35 ppapi/examples/media_stream_video/media_stream_video.cc:35: class MSVDemoModule : public pp::Module { ...
6 years, 11 months ago (2014-01-13 21:13:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/134643002/200001
6 years, 11 months ago (2014-01-13 21:31:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/134643002/200001
6 years, 11 months ago (2014-01-14 00:24:30 UTC) #11
commit-bot: I haz the power
Failed to trigger a try job on win HTTP Error 400: Bad Request
6 years, 11 months ago (2014-01-14 03:34:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/134643002/570001
6 years, 11 months ago (2014-01-14 03:34:36 UTC) #13
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 13:50:24 UTC) #14
Message was sent while issue was closed. 
Change committed as 244686

Powered by Google App Engine
This is Rietveld 408576698