Skia: Add Command Buffer support to Linux/Mac

Skia: Add Command Buffer support to Linux/Mac

Code added to load libcommand_buffer_gles2.so on linux or
mac.

Committed: https://skia.googlesource.com/skia/+/b1ac52fb0f8c5f03844ef3bbb198ba32427194b5

[hendrikw, 2015-09-16 22:59:21]

hendrikw@chromium.org changed reviewers:
+ bsalomon@google.com

[hendrikw, 2015-09-16 22:59:22]

PTAL

Question: It's probably a good idea to move the windows vs. linux lib and
procedure loading code to somewhere shared.  Where do you think would be good?

[bsalomon, 2015-09-21 14:50:08]

On 2015/09/16 22:59:22, hendrikw wrote:
> PTAL
> 
> Question: It's probably a good idea to move the windows vs. linux lib and
> procedure loading code to somewhere shared.  Where do you think would be good?

Maybe somewhere under [include|src]/ports?

[hendrikw, 2015-10-01 00:50:23]

The CQ bit was checked by hendrikw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 00:50:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346423002/40001

[commit-bot: I haz the power, 2015-10-01 00:50:35]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-10-01 06:50 UTC

[commit-bot: I haz the power, 2015-10-01 00:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 00:51:23]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[bsalomon, 2015-10-01 12:52:00]

https://chromiumcodereview.appspot.com/1346423002/diff/40001/include/private/...
File include/private/SkOSLibrary.h (right):

https://chromiumcodereview.appspot.com/1346423002/diff/40001/include/private/...
include/private/SkOSLibrary.h:2: /*
I'm not a fan of this policy, but the current deal is that headers only go in
include/private if they are required in another header which itself is under
/include. So, I think this should be in src/ports.

Otherwise, lgtm.

[hendrikw, 2015-10-01 21:40:12]

The CQ bit was checked by hendrikw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 22:31:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346423002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346423002/80001

[commit-bot: I haz the power, 2015-10-01 22:33:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 22:33:29]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[hendrikw, 2015-10-02 01:22:09]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2015-10-02 01:22:09]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1346423002/#ps100001
(title: "make windows compile")

[commit-bot: I haz the power, 2015-10-02 01:22:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346423002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346423002/100001

[commit-bot: I haz the power, 2015-10-02 01:29:40]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/b1ac52fb0f8c5f03844ef3bbb198ba32427194b5