Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1346263004: [turbofan] Greedy: faster compile time. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Greedy: faster compile time. Avoiding unnecessarily traversing conflicts when doing weight comparisons. This reduced compile time regressions from a few multiples to under 10% - at least for zlib. Committed: https://crrev.com/1145090ad551ff3a8a8ce2e2adc9793eeca2a2c4 Cr-Commit-Position: refs/heads/master@{#30783}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M src/compiler/greedy-allocator.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/greedy-allocator.cc View 1 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-09-17 01:48:16 UTC) #2
Benedikt Meurer
Nice. LGTM.
5 years, 3 months ago (2015-09-17 03:52:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346263004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346263004/40001
5 years, 3 months ago (2015-09-17 03:52:18 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-17 03:53:56 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 03:54:12 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1145090ad551ff3a8a8ce2e2adc9793eeca2a2c4
Cr-Commit-Position: refs/heads/master@{#30783}

Powered by Google App Engine
This is Rietveld 408576698