Issue 1346253003: win: Fix always-rebuild of crashpad_snapshot_test_image_reader_module.dll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1346253003: win: Fix always-rebuild of crashpad_snapshot_test_image_reader_module.dll (Closed)

Created:
5 years, 3 months ago by scottmg

Modified:
5 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: Fix always-rebuild of crashpad_snapshot_test_image_reader_module.dll Ninja assumes all DLLs will have an import library generated (caused when there are any exports), but because this DLL is so simple, it does not. This makes ninja think that the target is always dirty and so it rebuilds it on every build. Fix this by telling ninja not to expect an import library. R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/d1d341c7199dc857b21adf60dcb7747669862560

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	snapshot/snapshot_test.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

5 years, 3 months ago (2015-09-21 17:53:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d1d341c7199dc857b21adf60dcb7747669862560 (presubmit successful).

Expand Messages | Collapse Messages