Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

Issue 134623005: Make SingleThreadProxy a SchedulerClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests; remove weak_ptr_ Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/thread_proxy.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/compositor/software_browser_compositor_output_surface_unittest.cc
diff --git a/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc b/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc
index dc80da1a0f20947959bf38e8265eeb18dee2737f..3c1ec16f78d95bec870b87acf645dd40174b619b 100644
--- a/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc
+++ b/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc
@@ -9,6 +9,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/compositor/compositor.h"
#include "ui/compositor/test/context_factories_for_test.h"
+#include "ui/compositor/test/test_compositor_host.h"
#include "ui/gfx/vsync_provider.h"
namespace {
@@ -70,11 +71,12 @@ class SoftwareBrowserCompositorOutputSurfaceTest : public testing::Test {
scoped_ptr<content::BrowserCompositorOutputSurface> output_surface_;
scoped_ptr<base::MessageLoop> message_loop_;
- scoped_ptr<ui::Compositor> compositor_;
IDMap<content::BrowserCompositorOutputSurface> surface_map_;
scoped_refptr<content::BrowserCompositorOutputSurfaceProxy> surface_proxy_;
+ scoped_ptr<ui::TestCompositorHost> window_;
danakj 2014/02/21 19:36:21 s/window_/compositor_host_/
enne (OOO) 2014/02/21 19:41:32 Done. PS https://code.google.com/p/chromium/codes
+
DISALLOW_COPY_AND_ASSIGN(SoftwareBrowserCompositorOutputSurfaceTest);
};
@@ -93,14 +95,17 @@ void SoftwareBrowserCompositorOutputSurfaceTest::SetUp() {
ui::InitializeContextFactoryForTests(enable_pixel_output);
ui::Compositor::Initialize();
- compositor_.reset(new ui::Compositor(gfx::kNullAcceleratedWidget));
+ const gfx::Rect host_bounds(10, 10, 500, 500);
+ window_.reset(ui::TestCompositorHost::Create(host_bounds));
+ window_->Show();
+
surface_proxy_ =
new content::BrowserCompositorOutputSurfaceProxy(&surface_map_);
}
void SoftwareBrowserCompositorOutputSurfaceTest::TearDown() {
output_surface_.reset();
- compositor_.reset();
+ window_.reset();
EXPECT_TRUE(surface_map_.IsEmpty());
@@ -118,7 +123,7 @@ SoftwareBrowserCompositorOutputSurfaceTest::CreateSurface(
device.Pass(),
1,
&surface_map_,
- compositor_->vsync_manager()));
+ window_->GetCompositor()->vsync_manager()));
}
TEST_F(SoftwareBrowserCompositorOutputSurfaceTest, NoVSyncProvider) {
« no previous file with comments | « cc/trees/thread_proxy.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698