content/shell/renderer/test_runner/web_test_proxy.cc - Issue 134623005: Make SingleThreadProxy a SchedulerClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/web_test_proxy.cc

Issue 134623005: Make SingleThreadProxy a SchedulerClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add scoped_abort_remaining_swap_promises.h Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/test_runner/web_test_proxy.cc

diff --git a/content/shell/renderer/test_runner/web_test_proxy.cc b/content/shell/renderer/test_runner/web_test_proxy.cc

index 7e36976482f629bd7a9950aa94f066cb599a3137..18086de32ee8f1eb6b975bb02ad542c083b682a3 100644

--- a/content/shell/renderer/test_runner/web_test_proxy.cc

+++ b/content/shell/renderer/test_runner/web_test_proxy.cc

@@ -7,9 +7,11 @@

#include <cctype>

#include "base/callback_helpers.h"

+#include "base/command_line.h"

#include "base/debug/trace_event.h"

#include "base/logging.h"

#include "base/strings/stringprintf.h"

+#include "content/public/common/content_switches.h"

#include "content/shell/renderer/test_runner/TestPlugin.h"

#include "content/shell/renderer/test_runner/WebTestDelegate.h"

#include "content/shell/renderer/test_runner/WebTestInterfaces.h"

@@ -313,6 +315,10 @@ WebTestProxyBase::WebTestProxyBase()

web_widget_(NULL),

spellcheck_(new SpellCheckClient(this)),

chooser_count_(0) {

+ // TODO(enne): using the scheduler introduces additional composite steps

+ // that create flakiness. This should go away eventually.

+ base::CommandLine::ForCurrentProcess()->AppendSwitch(

+ switches::kDisableSingleThreadProxyScheduler);

Reset();

}