Make SingleThreadProxy a SchedulerClient

content/renderer/render_widget.cc

Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 73ab00862d967b0b3e2574d512c08cb8397fe76c..94d1ecc5c99c34a54eb50782a88bf4a149540e19 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -386,6 +386,7 @@ RenderWidget::RenderWidget(blink::WebPopupType popup_type,
       handling_event_type_(WebInputEvent::Undefined),
       ignore_ack_for_mouse_move_from_debugger_(false),
       closing_(false),
+      host_closing_(false),
       is_swapped_out_(swapped_out),
       input_method_is_active_(false),
       text_input_type_(ui::TEXT_INPUT_TYPE_NONE),
@@ -1172,6 +1173,8 @@ void RenderWidget::AutoResizeCompositor()  {
 }
 
 void RenderWidget::initializeLayerTreeView() {
+  DCHECK(!host_closing_);
+
   compositor_ = RenderWidgetCompositor::Create(
       this, is_threaded_compositing_enabled_);
   compositor_->setViewportSize(size_, physical_backing_size_);
@@ -1179,20 +1182,20 @@ void RenderWidget::initializeLayerTreeView() {
     StartCompositor();
 }
 
-blink::WebLayerTreeView* RenderWidget::layerTreeView() {
-  return compositor_.get();
+void RenderWidget::DestroyLayerTreeView() {
+  // Always send this notification to prevent new layer tree views from

[enne (OOO), 2014/07/10 20:37:42]

This fixed a race where the layer tree view would try to be created for the
first time while shutting down.

+  // being created, even if one hasn't been created yet.
+  webwidget_->willCloseLayerTreeView();
+  compositor_.reset();
 }
 
-void RenderWidget::suppressCompositorScheduling(bool enable) {
-  if (compositor_)
-    compositor_->SetSuppressScheduleComposite(enable);
+blink::WebLayerTreeView* RenderWidget::layerTreeView() {
+  return compositor_.get();
 }
 
 void RenderWidget::willBeginCompositorFrame() {
   TRACE_EVENT0("gpu", "RenderWidget::willBeginCompositorFrame");
 
-  DCHECK(RenderThreadImpl::current()->compositor_message_loop_proxy().get());
-
   // The following two can result in further layout and possibly
   // enable GPU acceleration so they need to be called before any painting
   // is done.
@@ -1296,6 +1299,12 @@ void RenderWidget::didBlur() {
 }
 
 void RenderWidget::DoDeferredClose() {
+  // No more compositing is possible.  This prevents shutdown races between
+  // previously posted CreateOutputSurface tasks and the host being unable to
+  // create them because the close message was handled.
+  DestroyLayerTreeView();
+  // Also prevent new compositors from being created.
+  host_closing_ = true;
   Send(new ViewHostMsg_Close(routing_id_));
 }
 
@@ -1336,8 +1345,7 @@ void RenderWidget::QueueSyntheticGesture(
 void RenderWidget::Close() {
   screen_metrics_emulator_.reset();
   if (webwidget_) {
-    webwidget_->willCloseLayerTreeView();
-    compositor_.reset();
+    DestroyLayerTreeView();
     webwidget_->close();
     webwidget_ = NULL;
   }