Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: content/renderer/render_widget.cc

Issue 134623005: Make SingleThreadProxy a SchedulerClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 73ab00862d967b0b3e2574d512c08cb8397fe76c..0b67c25c5097b56dee79c7081a3520a27fe90bbd 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -386,6 +386,7 @@ RenderWidget::RenderWidget(blink::WebPopupType popup_type,
handling_event_type_(WebInputEvent::Undefined),
ignore_ack_for_mouse_move_from_debugger_(false),
closing_(false),
+ host_closing_(false),
is_swapped_out_(swapped_out),
input_method_is_active_(false),
text_input_type_(ui::TEXT_INPUT_TYPE_NONE),
@@ -1172,6 +1173,11 @@ void RenderWidget::AutoResizeCompositor() {
}
void RenderWidget::initializeLayerTreeView() {
+ // The host is currently shutting down and any old compositors have
+ // been destroyed, so don't create any new ones.
+ if (host_closing_)
+ return;
+
compositor_ = RenderWidgetCompositor::Create(
this, is_threaded_compositing_enabled_);
compositor_->setViewportSize(size_, physical_backing_size_);
@@ -1179,6 +1185,13 @@ void RenderWidget::initializeLayerTreeView() {
StartCompositor();
}
+void RenderWidget::DestroyLayerTreeView() {
+ if (!compositor_)
+ return;
+ webwidget_->willCloseLayerTreeView();
+ compositor_.reset();
+}
+
blink::WebLayerTreeView* RenderWidget::layerTreeView() {
return compositor_.get();
}
@@ -1191,8 +1204,6 @@ void RenderWidget::suppressCompositorScheduling(bool enable) {
void RenderWidget::willBeginCompositorFrame() {
TRACE_EVENT0("gpu", "RenderWidget::willBeginCompositorFrame");
- DCHECK(RenderThreadImpl::current()->compositor_message_loop_proxy().get());
-
// The following two can result in further layout and possibly
// enable GPU acceleration so they need to be called before any painting
// is done.
@@ -1296,6 +1307,12 @@ void RenderWidget::didBlur() {
}
void RenderWidget::DoDeferredClose() {
+ // No more compositing is possible. This prevents shutdown races between
+ // previously posted CreateOutputSurface tasks and the host being unable to
+ // create them because the close message was handled.
+ DestroyLayerTreeView();
+ // Also prevent new compositors from being created.
+ host_closing_ = true;
Send(new ViewHostMsg_Close(routing_id_));
}
@@ -1336,8 +1353,7 @@ void RenderWidget::QueueSyntheticGesture(
void RenderWidget::Close() {
screen_metrics_emulator_.reset();
if (webwidget_) {
- webwidget_->willCloseLayerTreeView();
- compositor_.reset();
+ DestroyLayerTreeView();
webwidget_->close();
webwidget_ = NULL;
}

Powered by Google App Engine
This is Rietveld 408576698