Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: chromeos/power/power_data_collector.cc

Issue 134623002: [chromeos] Limit the data samples stored by PowerDataCollector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address nits Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chromeos/power/power_data_collector.h ('k') | chromeos/power/power_data_collector_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/power/power_data_collector.h" 5 #include "chromeos/power/power_data_collector.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chromeos/dbus/dbus_thread_manager.h" 8 #include "chromeos/dbus/dbus_thread_manager.h"
9 #include "chromeos/dbus/power_manager/power_supply_properties.pb.h" 9 #include "chromeos/dbus/power_manager/power_supply_properties.pb.h"
10 10
11 namespace chromeos { 11 namespace chromeos {
12 12
13 namespace { 13 namespace {
14 14
15 // The global PowerDataCollector instance. 15 // The global PowerDataCollector instance.
16 PowerDataCollector* g_power_data_collector = NULL; 16 PowerDataCollector* g_power_data_collector = NULL;
17 17
18 } // namespace 18 } // namespace
19 19
20 const int PowerDataCollector::kSampleTimeLimitSec = 24 * 60 * 60;
21
20 // static 22 // static
21 void PowerDataCollector::Initialize() { 23 void PowerDataCollector::Initialize() {
22 // Check that power data collector is initialized only after the 24 // Check that power data collector is initialized only after the
23 // DBusThreadManager is initialized. 25 // DBusThreadManager is initialized.
24 CHECK(DBusThreadManager::Get()); 26 CHECK(DBusThreadManager::Get());
25 CHECK(g_power_data_collector == NULL); 27 CHECK(g_power_data_collector == NULL);
26 g_power_data_collector = new PowerDataCollector(); 28 g_power_data_collector = new PowerDataCollector();
27 } 29 }
28 30
29 // static 31 // static
(...skipping 10 matching lines...) Expand all
40 return g_power_data_collector; 42 return g_power_data_collector;
41 } 43 }
42 44
43 void PowerDataCollector::PowerChanged( 45 void PowerDataCollector::PowerChanged(
44 const power_manager::PowerSupplyProperties& prop) { 46 const power_manager::PowerSupplyProperties& prop) {
45 PowerSupplySnapshot snapshot; 47 PowerSupplySnapshot snapshot;
46 snapshot.time = base::TimeTicks::Now(); 48 snapshot.time = base::TimeTicks::Now();
47 snapshot.external_power = (prop.external_power() != 49 snapshot.external_power = (prop.external_power() !=
48 power_manager::PowerSupplyProperties::DISCONNECTED); 50 power_manager::PowerSupplyProperties::DISCONNECTED);
49 snapshot.battery_percent = prop.battery_percent(); 51 snapshot.battery_percent = prop.battery_percent();
50 52 AddSnapshot(snapshot);
51 power_supply_data_.push_back(snapshot);
52 } 53 }
53 54
54 PowerDataCollector::PowerDataCollector() { 55 PowerDataCollector::PowerDataCollector() {
55 DBusThreadManager::Get()->GetPowerManagerClient()->AddObserver(this); 56 DBusThreadManager::Get()->GetPowerManagerClient()->AddObserver(this);
56 } 57 }
57 58
58 PowerDataCollector::~PowerDataCollector() { 59 PowerDataCollector::~PowerDataCollector() {
59 DBusThreadManager* dbus_manager = DBusThreadManager::Get(); 60 DBusThreadManager* dbus_manager = DBusThreadManager::Get();
60 CHECK(dbus_manager); 61 CHECK(dbus_manager);
61 dbus_manager->GetPowerManagerClient()->RemoveObserver(this); 62 dbus_manager->GetPowerManagerClient()->RemoveObserver(this);
62 } 63 }
63 64
65 void PowerDataCollector::AddSnapshot(const PowerSupplySnapshot& snapshot) {
66 while (!power_supply_data_.empty()) {
67 const PowerSupplySnapshot& first = power_supply_data_.front();
68 if (snapshot.time - first.time >
69 base::TimeDelta::FromSeconds(kSampleTimeLimitSec)) {
70 power_supply_data_.pop_front();
71 } else {
72 break;
73 }
74 }
75 power_supply_data_.push_back(snapshot);
76 }
77
64 PowerDataCollector::PowerSupplySnapshot::PowerSupplySnapshot() 78 PowerDataCollector::PowerSupplySnapshot::PowerSupplySnapshot()
65 : time(base::TimeTicks::Now()), 79 : time(base::TimeTicks::Now()),
66 external_power(false), 80 external_power(false),
67 battery_percent(0) { 81 battery_percent(0) {
68 } 82 }
69 83
70 } // namespace chromeos 84 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/power/power_data_collector.h ('k') | chromeos/power/power_data_collector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698