Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 13462003: Add support for accelerated fixed root background

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 13462003: Add support for accelerated fixed root background (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@background-attachment-fixed2

Patch Set: Moved the layout tests. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/compositing/fixed-background-negative-z-index-fixed.html ('K') | « Source/core/page/Settings.in ('k') | Source/core/rendering/RenderLayerBacking.h » ('j') | Source/core/rendering/RenderLayerBacking.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/Source/core/page/scrolling/ScrollingCoordinator.cpp b/Source/core/page/scrolling/ScrollingCoordinator.cpp

index 9afb665ec108b769395523a53d0e532ff3313453..61e447573b0a1faf1c9c8b8da05aed17acca5f28 100644

--- a/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -159,7 +159,6 @@ void ScrollingCoordinator::updateLayerPositionConstraint(RenderLayer* layer)

// Avoid unnecessary commits

clearPositionConstraintExceptForLayer(backing->ancestorClippingLayer(), mainLayer);

- clearPositionConstraintExceptForLayer(backing->contentsContainmentLayer(), mainLayer);

clearPositionConstraintExceptForLayer(backing->graphicsLayer(), mainLayer);

if (WebLayer* scrollableLayer = scrollingWebLayerForGraphicsLayer(mainLayer))