Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346143005: Scale objectBoundingBox units for primitive dimensions w/ -webkit-filter (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), gyuyoung2, jbroman, jchaffraix+rendering, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Scale objectBoundingBox units for primitive dimensions w/ -webkit-filter Minor mismatch with the other code-path (in SVGFilterPainter). Drop the default argument value from the 4-ary Filter::create(). BUG=532938 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
A LayoutTests/css3/filters/effect-reference-obb-dimensions.html View 1 chunk +21 lines, -0 lines 0 comments Download
A + LayoutTests/css3/filters/effect-reference-obb-dimensions-expected.html View 1 chunk +6 lines, -4 lines 0 comments Download
M Source/core/layout/svg/ReferenceFilterBuilder.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/platform/graphics/filters/Filter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 3 months ago (2015-09-18 11:36:17 UTC) #2
Stephen White
LGTM. Thanks for the fix!
5 years, 3 months ago (2015-09-18 14:33:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346143005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346143005/1
5 years, 3 months ago (2015-09-18 14:35:53 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 14:41:06 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202522

Powered by Google App Engine
This is Rietveld 408576698