Issue 134613002: Modify some Linux flags for better GYP fidelity in GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134613002: Modify some Linux flags for better GYP fidelity in GN build. (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Modify some Linux flags for better GYP fidelity in GN build. R=scottmg@chromium.org TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244539

Patch Set 2 : #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	build/config/compiler/BUILD.gn	View		3 chunks	+23 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/134613002/diff/20002/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/134613002/diff/20002/build/config/compiler/BUILD.gn#newcode133 build/config/compiler/BUILD.gn:133: # TODO(phajdan.jr): Should we enable this for all ...

6 years, 11 months ago (2014-01-10 19:58:07 UTC) #3

brettw

6 years, 11 months ago (2014-01-13 18:26:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r244539 (presubmit successful).

Expand Messages | Collapse Messages

Issue 134613002: Modify some Linux flags for better GYP fidelity in GN build. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages