Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 13461012: Omnibox: Speed Up SearchProviderTest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/search_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index 5237c18f046e43e6a717daf06dc2addb0e020845..16f669f3bc095ccbc56d6f9629670011c1f3eece 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -29,6 +29,7 @@
#include "net/url_request/url_fetcher_delegate.h"
class Profile;
+class SearchProviderTest;
class TemplateURLService;
namespace base {
@@ -52,6 +53,12 @@ class URLFetcher;
class SearchProvider : public AutocompleteProvider,
public net::URLFetcherDelegate {
public:
+ // ID used in creating URLFetcher for default provider's suggest results.
+ static const int kDefaultProviderURLFetcherID;
+
+ // ID used in creating URLFetcher for keyword provider's suggest results.
+ static const int kKeywordProviderURLFetcherID;
+
SearchProvider(AutocompleteProviderListener* listener, Profile* profile);
// Marks the instant query as done. If |input_text| is non-empty this changes
@@ -84,19 +91,18 @@ class SearchProvider : public AutocompleteProvider,
return field_trial_triggered_in_session_;
}
- // ID used in creating URLFetcher for default provider's suggest results.
- static const int kDefaultProviderURLFetcherID;
-
- // ID used in creating URLFetcher for keyword provider's suggest results.
- static const int kKeywordProviderURLFetcherID;
-
private:
+ friend class SearchProviderTest;
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, SuggestRelevanceExperiment);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInline);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInlineSchemeSubstring);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInlineDomainClassify);
FRIEND_TEST_ALL_PREFIXES(AutocompleteProviderTest, GetDestinationURL);
+ // The amount of time to wait before sending a new suggest request after
+ // the previous one.
+ static int kMinimumTimeBetweenSuggestQueriesMs;
+
virtual ~SearchProvider();
// Manages the providers (TemplateURLs) used by SearchProvider. Two providers
« no previous file with comments | « no previous file | chrome/browser/autocomplete/search_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698