Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 13461012: Omnibox: Speed Up SearchProviderTest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mike's comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index 03de46fdb073de429df041677314984ea9ea91da..1dc8776d152424cd740fb56b057ee069b92180c9 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -28,6 +28,7 @@
#include "chrome/common/instant_types.h"
#include "net/url_request/url_fetcher_delegate.h"
+class SearchProviderTest;
msw 2013/04/03 23:28:48 nit: alphabetize this.
Mark P 2013/04/03 23:58:39 Done.
class Profile;
class TemplateURLService;
@@ -91,6 +92,7 @@ class SearchProvider : public AutocompleteProvider,
static const int kKeywordProviderURLFetcherID;
private:
+ friend class SearchProviderTest;
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, SuggestRelevanceExperiment);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInline);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInlineSchemeSubstring);
@@ -246,6 +248,10 @@ class SearchProvider : public AutocompleteProvider,
class CompareScoredResults;
+ // The amount of time to wait before sending a new suggest request after
+ // the previous one.
+ static int kMinimumTimeBetweenSuggestQueriesMs;
msw 2013/04/03 23:28:48 This belongs at line 102 before "virtual ~SearchPr
Mark P 2013/04/03 23:58:39 Done.
+
// Called when timer_ expires.
void Run();
« no previous file with comments | « no previous file | chrome/browser/autocomplete/search_provider.cc » ('j') | chrome/browser/autocomplete/search_provider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698