Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1346043005: X87: Remove --pretenure-call-new (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove --pretenure-call-new port b5588f48fd0b4e3ee43be1fe6c19d7ddd8b8b5f1 (r30767). original commit message: There isn't a plan to turn it on soon, so we'll take it out in favor of cleaner code. BUG= Committed: https://crrev.com/d10b2709dfa1b5dcb8a83ea97491b7728169d472 Cr-Commit-Position: refs/heads/master@{#30829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -121 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/x87/builtins-x87.cc View 9 chunks +7 lines, -57 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 3 chunks +36 lines, -49 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-18 07:16:52 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-18 11:21:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346043005/1
5 years, 3 months ago (2015-09-18 11:22:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 12:00:53 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 12:01:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d10b2709dfa1b5dcb8a83ea97491b7728169d472
Cr-Commit-Position: refs/heads/master@{#30829}

Powered by Google App Engine
This is Rietveld 408576698