Issue 134603003: Resizes all docked windows that are flush with the docked edge in sync

Issue 134603003: Resizes all docked windows that are flush with the docked edge in sync (Closed)

Created:
6 years, 11 months ago by varkha

Modified:
6 years, 11 months ago

Reviewers:
oshima

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@panels

Visibility:
Public.

More Reviews

Description

Resizes all docked windows that are flush with the docked edge in sync BUG=301940 TEST=ash_unittests --gtest_filter=*DockedWindowResizerTest.ResizeTwoWindows/* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244365

Patch Set 1 : Resizes all docked windows that are flush with thedocked edge in sync #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -4 lines)			Patch
	M	ash/wm/dock/docked_window_layout_manager.cc	View		2 chunks	+20 lines, -1 line	2 comments	Download
	M	ash/wm/dock/docked_window_resizer_unittest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

varkha

oshima@, could you please take a look? This allows the docked windows to stay as ...

6 years, 11 months ago (2014-01-10 19:49:39 UTC) #1

oshima

one q https://codereview.chromium.org/134603003/diff/30001/ash/wm/dock/docked_window_layout_manager.cc File ash/wm/dock/docked_window_layout_manager.cc (right): https://codereview.chromium.org/134603003/diff/30001/ash/wm/dock/docked_window_layout_manager.cc#newcode453 ash/wm/dock/docked_window_layout_manager.cc:453: wm::GetWindowState(window1)->set_bounds_changed_by_user(false); so this will trigger resizing later ...

6 years, 11 months ago (2014-01-10 23:07:28 UTC) #2

varkha

https://codereview.chromium.org/134603003/diff/30001/ash/wm/dock/docked_window_layout_manager.cc File ash/wm/dock/docked_window_layout_manager.cc (right): https://codereview.chromium.org/134603003/diff/30001/ash/wm/dock/docked_window_layout_manager.cc#newcode453 ash/wm/dock/docked_window_layout_manager.cc:453: wm::GetWindowState(window1)->set_bounds_changed_by_user(false); On 2014/01/10 23:07:28, oshima wrote: > so this ...

6 years, 11 months ago (2014-01-10 23:26:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/134603003/30001

6 years, 11 months ago (2014-01-11 03:13:55 UTC) #5

Message was sent while issue was closed.

Change committed as 244365

Expand Messages | Collapse Messages