Issue 134603002: Fix bottom padding on flex boxes with overflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134603002: Fix bottom padding on flex boxes with overflow. (Closed)

Created:
6 years, 11 months ago by ojan

Modified:
6 years, 11 months ago

Reviewers:
eseidel, esprehn, abarth-chromium

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix bottom padding on flex boxes with overflow. This makes display:flex match display:block. Unfortunately, our display:block behavior does not match Gecko or IE8+ though. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165031

Patch Set 1 #

Patch Set 2 : fix layout test #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -3 lines)			Patch
M	LayoutTests/css3/flexbox/negative-overflow.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A	LayoutTests/css3/flexbox/overflow-and-padding.html	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	LayoutTests/css3/flexbox/overflow-and-padding-expected.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderFlexibleBox.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/134603002/1

6 years, 11 months ago (2014-01-10 23:26:19 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=17259

6 years, 11 months ago (2014-01-11 00:12:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/134603002/140001

6 years, 11 months ago (2014-01-14 01:50:12 UTC) #5

Message was sent while issue was closed.

Change committed as 165031

Expand Messages | Collapse Messages