elements.cc cleanup

elements.cc cleanup

Reuse code for copying arguments and pushing/shifting elements.

BUG=

Committed: https://crrev.com/061e2a9b2b1cf70cb1c18ea6425219e8bd592903
Cr-Commit-Position: refs/heads/master@{#30825}

[Camillo Bruni, 2015-09-17 14:59:44]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-17 14:59:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346013005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346013005/1

[Camillo Bruni, 2015-09-17 15:07:25]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Camillo Bruni, 2015-09-17 15:07:25]

PTAL

[commit-bot: I haz the power, 2015-09-17 15:25:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-17 15:25:07]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2015-09-18 10:29:54]

LGTM with nits.

https://codereview.chromium.org/1346013005/diff/1/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1346013005/diff/1/src/elements.cc#newcode1463
src/elements.cc:1463: // partially copy all elements up to start
nit: While you're here, please fix capitalization and punctuation.

https://codereview.chromium.org/1346013005/diff/1/src/elements.cc#newcode1478
src/elements.cc:1478: bool removeAtStart) {
Instead of a bool, please use an enum (which can be local to this file), e.g.: 

enum Where { AT_START, AT_END };

(also, nit: "remove_at_start" would have been the preferred capitalization)

https://codereview.chromium.org/1346013005/diff/1/src/elements.cc#newcode1504
src/elements.cc:1504: bool addAtStart) {
same here

[Camillo Bruni, 2015-09-18 10:44:25]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-09-18 10:44:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1346013005/#ps20001
(title: "addressing nits")

[commit-bot: I haz the power, 2015-09-18 10:44:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346013005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346013005/20001

[commit-bot: I haz the power, 2015-09-18 11:15:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-18 11:16:01]

Patchset 2 (id:??) landed as
https://crrev.com/061e2a9b2b1cf70cb1c18ea6425219e8bd592903
Cr-Commit-Position: refs/heads/master@{#30825}