Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 1346003002: Always expose libdrm dependency when chromeos==1 (Closed)

Created:
5 years, 3 months ago by spang
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always expose libdrm dependency when chromeos==1 This fixes a build break for linux chromeos: gyp: Dependency '/b/build/slave/linux_chromeos/build/src/build/linux/system.gyp:libdrm#target' not found while trying to load target /b/build/slave/linux_chromeos/build/src/content/content_shell_and_tests.gyp:vaapi_jpeg_decoder_unittest#target BUG=531814 TEST=gclient runhooks with "use_ozone=1 chromeos=1" Committed: https://crrev.com/35ecf40fb75893838295418d07fa5d37bcca10d7 Cr-Commit-Position: refs/heads/master@{#349057}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/linux/system.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
spang
5 years, 3 months ago (2015-09-16 01:11:06 UTC) #2
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/35ecf40fb75893838295418d07fa5d37bcca10d7 Cr-Commit-Position: refs/heads/master@{#349057}
5 years, 3 months ago (2015-09-16 01:14:17 UTC) #3
spang
Committed patchset #2 (id:20001) manually as 35ecf40fb75893838295418d07fa5d37bcca10d7 (tree was closed).
5 years, 3 months ago (2015-09-16 01:14:34 UTC) #4
Dirk Pranke
doesn't use_ozone=1 (and ozone_auto_platforms==1, which is the default) imply ozone_platform_gbm=1 ? i.e., does setting chromeos=1 ...
5 years, 3 months ago (2015-09-16 01:16:09 UTC) #5
spang
On 2015/09/16 01:16:09, Dirk Pranke wrote: > doesn't use_ozone=1 (and ozone_auto_platforms==1, which is the default) ...
5 years, 3 months ago (2015-09-16 01:19:11 UTC) #6
Dirk Pranke
On 2015/09/16 01:19:11, spang wrote: > On 2015/09/16 01:16:09, Dirk Pranke wrote: > > doesn't ...
5 years, 3 months ago (2015-09-16 01:20:41 UTC) #7
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-16 01:20:48 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:52:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35ecf40fb75893838295418d07fa5d37bcca10d7
Cr-Commit-Position: refs/heads/master@{#349057}

Powered by Google App Engine
This is Rietveld 408576698