media/capture/video/linux/video_capture_device_linux.cc - Issue 1345993002: Change the functions in video_capture_device to pass around PowerLineFrequency enums instead of int…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/linux/video_capture_device_linux.cc

Issue 1345993002: Change the functions in video_capture_device to pass around PowerLineFrequency enums instead of int… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/capture/video/linux/video_capture_device_linux.h ('k') | media/capture/video/mac/video_capture_device_mac.mm » ('j') | media/capture/video/mac/video_capture_device_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/capture/video/linux/video_capture_device_linux.cc

diff --git a/media/capture/video/linux/video_capture_device_linux.cc b/media/capture/video/linux/video_capture_device_linux.cc

index f4ca749ae9b69a6961c3ab3b41b96edd9360492d..aa224af73393ced048e35ff9da719df35a82b120 100644

--- a/media/capture/video/linux/video_capture_device_linux.cc

+++ b/media/capture/video/linux/video_capture_device_linux.cc

@@ -132,11 +132,12 @@ void VideoCaptureDeviceLinux::SetRotation(int rotation) {

}

// static

-int VideoCaptureDeviceLinux::TranslatePowerLineFrequencyToV4L2(int frequency) {

+int VideoCaptureDeviceLinux::TranslatePowerLineFrequencyToV4L2(

+ PowerLineFrequency frequency) {

ajose 2015/09/17 19:33:32 const

mcasas 2015/09/21 15:30:06 l.136 should be justified two further spaces right

switch (frequency) {

- case static_cast<int>(media::PowerLineFrequency::FREQUENCY_50HZ):

+ case media::PowerLineFrequency::FREQUENCY_50HZ:

return V4L2_CID_POWER_LINE_FREQUENCY_50HZ;

- case static_cast<int>(media::PowerLineFrequency::FREQUENCY_60HZ):

+ case media::PowerLineFrequency::FREQUENCY_60HZ:

return V4L2_CID_POWER_LINE_FREQUENCY_60HZ;

default:

// If we have no idea of the frequency, at least try and set it to AUTO.