Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1345983007: dart2js CPS: Clean up the S-Expression builder. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Cleanup. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index a536e0e4f498eb78fd47c143b66f18965c300233..67061f025fbaf79ae1f5c3dc9d0825d8e0d2a041 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -3370,9 +3370,9 @@ class JsIrBuilderVisitor extends IrBuilderVisitor {
'Isolate library and compiler mismatch.');
}
List<ir.Primitive> arguments = translateStaticArguments(argumentList,
- element, CallStructure.TWO_ARGS);
+ element, callStructure);
return irBuilder.buildStaticFunctionInvocation(element,
- CallStructure.TWO_ARGS, arguments,
+ callStructure, arguments,
sourceInformation:
sourceInformationBuilder.buildCall(node, node.selector));
}
@@ -3521,12 +3521,12 @@ class JsIrBuilderVisitor extends IrBuilderVisitor {
if (!compiler.hasIsolateSupport) {
// If the isolate library is not used, we just generate code
// to fetch the current isolate.
- continue GET_STATIC_STATE;
+ continue getStaticState;
}
return buildIsolateHelperInvocation('_currentIsolate',
CallStructure.NO_ARGS);
- GET_STATIC_STATE: case 'JS_GET_STATIC_STATE':
+ getStaticState: case 'JS_GET_STATIC_STATE':
validateArgumentCount(exactly: 0);
return irBuilder.buildForeignCode(
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698