Issue 1345953002: Merge to XFA: Implement FPDFAction_GetFilePath().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1345953002: Merge to XFA: Implement FPDFAction_GetFilePath(). (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Implement FPDFAction_GetFilePath(). The API is the same as the Foxit version, except the encoding is specified as UTF-8 instead of local encoding. Also remove CPDF_LWinParam since it's unused. BUG=chromium:517713 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1335373002 . (cherry picked from commit 0b3c8f742613da294f812e2f6e908f4026499f96) (cherry picked from commit a9d4bc541179ec0436adc4b2e18b7fdecc5952dc) (cherry picked from commit 4ffd89ed556e32a6527d0e88952fe20ec1e2f362) Committed: https://pdfium.googlesource.com/pdfium/+/e0947b37c012144cefb523a33e548d3fadc211d8

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -109 lines)			Patch
M	core/include/fpdfdoc/fpdf_doc.h	View	3 chunks	+0 lines, -20 lines	0 comments	Download
M	core/src/fpdfdoc/doc_action.cpp	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	fpdfsdk/src/fpdfdoc.cpp	View	4 chunks	+30 lines, -19 lines	0 comments	Download
M	fpdfsdk/src/fpdfdoc_embeddertest.cpp	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/fpdfview_c_api_test.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	public/fpdf_doc.h	View	3 chunks	+25 lines, -9 lines	0 comments	Download
A +	testing/resources/launch_action.in	View	1 chunk	+22 lines, -24 lines	0 comments	Download
A +	testing/resources/launch_action.pdf	View	2 chunks	+26 lines, -28 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

PTAL: conflicts in fpdfdoc.cpp, and merged fixed in fpdfdoc_embeddertest.cpp.

5 years, 3 months ago (2015-09-15 23:35:54 UTC) #1

Lei Zhang

5 years, 3 months ago (2015-09-17 21:51:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e0947b37c012144cefb523a33e548d3fadc211d8 (presubmit successful).