Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1345943009: Reland: Add accelerated VP9 decode infrastructure and an implementation for VA-API. (Closed)

Created:
5 years, 3 months ago by Pawel Osciak
Modified:
5 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Add accelerated VP9 decode infrastructure and an implementation for VA-API. This reverts commit 27c68f543e5eba779902447445dfb05ec3f5bf75. The CL was reverted due to a missing include on msan builder. Fixing that. Original CL description: Add accelerated VP9 decode infrastructure and an implementation for VA-API. - Add a hardware/platform-independent VP9Decoder class and related infrastructure, implementing AcceleratedVideoDecoder interface. VP9Decoder performs the initial stages of the decode process, which are to be done on host/in software, such as stream parsing and reference frame management. - Add a VP9Accelerator interface, used by the VP9Decoder to offload the remaining stages of the decode process to hardware. VP9Accelerator implementations are platform-specific. - Add the first implementation of VP9Accelerator - VaapiVP9Accelerator - and integrate it with VaapiVideoDecodeAccelerator, for devices which provide hardware VP9 acceleration through VA-API. Hook it up to the new infrastructure and VP9Decoder. - Extend Vp9Parser to provide functionality required by VP9Decoder and VP9Accelerator, including superframe parsing, handling of loop filter and segmentation initialization, state persistence across frames and resetting when needed. Also add code calculating segmentation dequants and loop filter levels. - Update vp9_parser_unittest to the new Vp9Parser interface and flow. TEST=vp9_parser_unittest,vda_unittest,Chrome VP9 playback BUG=chrome-os-partner:41469, chrome-os-partner:41470, chromium:525331 TBR=dpranke@chromium.org TBR=wuchengli@chromium.org,kcwu@chromium.org,sandersd@chromium.org,jorgelo@chromium.org,tommycli@chromium.org Committed: https://crrev.com/d94b2b080b381dfe4fbb1f8d53faded18d59f400 Cr-Commit-Position: refs/heads/master@{#349609}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1102 lines, -159 lines) Patch
M content/common/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 12 chunks +227 lines, -13 lines 0 comments Download
M content/common/gpu/media/vaapi_wrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
A content/common/gpu/media/vp9_decoder.h View 1 1 chunk +130 lines, -0 lines 0 comments Download
A content/common/gpu/media/vp9_decoder.cc View 1 chunk +180 lines, -0 lines 0 comments Download
A content/common/gpu/media/vp9_picture.h View 1 chunk +35 lines, -0 lines 0 comments Download
A + content/common/gpu/media/vp9_picture.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/vp9_parser.h View 10 chunks +122 lines, -52 lines 0 comments Download
M media/filters/vp9_parser.cc View 10 chunks +347 lines, -58 lines 0 comments Download
M media/filters/vp9_parser_unittest.cc View 5 chunks +41 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345943009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345943009/20001
5 years, 3 months ago (2015-09-18 03:58:43 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-18 04:03:49 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 04:04:59 UTC) #4
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d94b2b080b381dfe4fbb1f8d53faded18d59f400
Cr-Commit-Position: refs/heads/master@{#349609}

Powered by Google App Engine
This is Rietveld 408576698