Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: Source/core/svg/SVGAElement.h

Issue 134593005: Update SVG classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/svg/SVGAltGlyphElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 18 matching lines...) Expand all
29 namespace WebCore { 29 namespace WebCore {
30 30
31 class SVGAElement FINAL : public SVGGraphicsElement, 31 class SVGAElement FINAL : public SVGGraphicsElement,
32 public SVGURIReference { 32 public SVGURIReference {
33 public: 33 public:
34 static PassRefPtr<SVGAElement> create(Document&); 34 static PassRefPtr<SVGAElement> create(Document&);
35 35
36 private: 36 private:
37 explicit SVGAElement(Document&); 37 explicit SVGAElement(Document&);
38 38
39 virtual bool isValid() const { return SVGTests::isValid(); } 39 virtual bool isValid() const OVERRIDE { return SVGTests::isValid(); }
40 40
41 virtual String title() const; 41 virtual String title() const OVERRIDE;
42 virtual AtomicString target() const OVERRIDE { return AtomicString(svgTarget CurrentValue()); } 42 virtual AtomicString target() const OVERRIDE { return AtomicString(svgTarget CurrentValue()); }
43 43
44 bool isSupportedAttribute(const QualifiedName&); 44 bool isSupportedAttribute(const QualifiedName&);
45 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE; 45 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;
46 virtual void svgAttributeChanged(const QualifiedName&); 46 virtual void svgAttributeChanged(const QualifiedName&) OVERRIDE;
47 47
48 virtual RenderObject* createRenderer(RenderStyle*); 48 virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE;
49 49
50 virtual void defaultEventHandler(Event*); 50 virtual void defaultEventHandler(Event*) OVERRIDE;
51 51
52 virtual bool supportsFocus() const OVERRIDE; 52 virtual bool supportsFocus() const OVERRIDE;
53 virtual bool isMouseFocusable() const OVERRIDE; 53 virtual bool isMouseFocusable() const OVERRIDE;
54 virtual bool isKeyboardFocusable() const OVERRIDE; 54 virtual bool isKeyboardFocusable() const OVERRIDE;
55 virtual bool rendererIsFocusable() const OVERRIDE; 55 virtual bool rendererIsFocusable() const OVERRIDE;
56 virtual bool isURLAttribute(const Attribute&) const; 56 virtual bool isURLAttribute(const Attribute&) const OVERRIDE;
57 57
58 virtual bool willRespondToMouseClickEvents() OVERRIDE FINAL; 58 virtual bool willRespondToMouseClickEvents() OVERRIDE;
59 59
60 virtual bool childShouldCreateRenderer(const Node& child) const; 60 virtual bool childShouldCreateRenderer(const Node& child) const OVERRIDE;
61 61
62 BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGAElement) 62 BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGAElement)
63 // This declaration used to define a non-virtual "String& target() const " method, that clashes with "virtual String Element::target() const". 63 // This declaration used to define a non-virtual "String& target() const " method, that clashes with "virtual String Element::target() const".
64 // That's why it has been renamed to "svgTarget", the CodeGenerators tak e care of calling svgTargetAnimated() instead of targetAnimated(), see CodeGener ator.pm. 64 // That's why it has been renamed to "svgTarget", the CodeGenerators tak e care of calling svgTargetAnimated() instead of targetAnimated(), see CodeGener ator.pm.
65 DECLARE_ANIMATED_STRING(SVGTarget, svgTarget) 65 DECLARE_ANIMATED_STRING(SVGTarget, svgTarget)
66 DECLARE_ANIMATED_STRING(Href, href) 66 DECLARE_ANIMATED_STRING(Href, href)
67 END_DECLARE_ANIMATED_PROPERTIES 67 END_DECLARE_ANIMATED_PROPERTIES
68 }; 68 };
69 69
70 } // namespace WebCore 70 } // namespace WebCore
71 71
72 #endif // SVGAElement_h 72 #endif // SVGAElement_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/svg/SVGAltGlyphElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698