Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1345923002: Check for empty embedder data before using it in PDFium JS bindings. (Closed)

Created:
5 years, 3 months ago by Tom Sepez
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check for empty embedder data before using it in PDFium JS bindings. This was guarded by an assert, but the path is hit. BUG=528015 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/615d7aba0f7d53a78eb05fbd4ae0e1a7e1d3b103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M fpdfsdk/include/javascript/JS_Define.h View 7 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, for review.
5 years, 3 months ago (2015-09-15 22:28:34 UTC) #1
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-15 22:31:46 UTC) #2
Tom Sepez
5 years, 3 months ago (2015-09-15 22:42:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
615d7aba0f7d53a78eb05fbd4ae0e1a7e1d3b103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698