Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3019)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 1345913002: [MD settings] adding isNewTabPage setting radio buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js
index 64040af29d925aa8718ecef195779eee434a0425..d08b2db79be13b77c6c5f7ef0f797844e98636c5 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
-
/**
* 'cr-settings-appearance-page' is the settings page containing appearance
* settings.
@@ -22,6 +20,27 @@
Polymer({
is: 'cr-settings-appearance-page',
+ properties: {
+ /**
+ * Preferences state.
+ */
+ prefs: {
+ type: Object,
+ notify: true,
+ },
+
+ // prefs.homepage_is_newtabpage.value
+ isNewTabPageString: {
+ type: String,
+ notify: true,
Dan Beam 2015/09/15 23:44:44 observer: 'isNewTabPageChanged_',
dschuyler 2015/09/16 00:14:28 I added String in there. Done.
+ }
+ },
+
+ observers: [
+ 'homepage_is_newtabpageChanged(prefs.homepage_is_newtabpage.value)',
+ 'isNewTabPageStringChanged(isNewTabPageString)',
+ ],
+
/** @override */
attached: function() {
// Query the initial state.
@@ -33,14 +52,13 @@ Polymer({
this.setResetThemeEnabled.bind(this));
},
- properties: {
- /**
- * Preferences state.
- */
- prefs: {
- type: Object,
- notify: true,
- },
+ homepage_is_newtabpageChanged: function(newValue) {
+ this.isNewTabPageString = newValue ? 't' : 'f';
+ },
+
+ isNewTabPageStringChanged: function(newValue) {
+ this.set('prefs.homepage_is_newtabpage.value',
+ this.isNewTabPageString == 't' ? true : false);
},
Dan Beam 2015/09/15 23:44:44 ^ make these private
dschuyler 2015/09/16 00:14:28 Done.
setResetThemeEnabled: function(enabled) {

Powered by Google App Engine
This is Rietveld 408576698