Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 1345913002: [MD settings] adding isNewTabPage setting radio buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5
6
7 /** 5 /**
8 * 'cr-settings-appearance-page' is the settings page containing appearance 6 * 'cr-settings-appearance-page' is the settings page containing appearance
9 * settings. 7 * settings.
10 * 8 *
11 * Example: 9 * Example:
12 * 10 *
13 * <iron-animated-pages> 11 * <iron-animated-pages>
14 * <cr-settings-appearance-page prefs="{{prefs}}"> 12 * <cr-settings-appearance-page prefs="{{prefs}}">
15 * </cr-settings-appearance-page> 13 * </cr-settings-appearance-page>
16 * ... other pages ... 14 * ... other pages ...
17 * </iron-animated-pages> 15 * </iron-animated-pages>
18 * 16 *
19 * @group Chrome Settings Elements 17 * @group Chrome Settings Elements
20 * @element cr-settings-appearance-page 18 * @element cr-settings-appearance-page
21 */ 19 */
22 Polymer({ 20 Polymer({
23 is: 'cr-settings-appearance-page', 21 is: 'cr-settings-appearance-page',
24 22
23 properties: {
24 /**
25 * Preferences state.
26 */
27 prefs: {
28 type: Object,
29 notify: true,
30 },
31
32 // prefs.homepage_is_newtabpage.value
33 isNewTabPageString: {
34 type: String,
35 notify: true,
Dan Beam 2015/09/15 23:44:44 observer: 'isNewTabPageChanged_',
dschuyler 2015/09/16 00:14:28 I added String in there. Done.
36 }
37 },
38
39 observers: [
40 'homepage_is_newtabpageChanged(prefs.homepage_is_newtabpage.value)',
41 'isNewTabPageStringChanged(isNewTabPageString)',
42 ],
43
25 /** @override */ 44 /** @override */
26 attached: function() { 45 attached: function() {
27 // Query the initial state. 46 // Query the initial state.
28 cr.sendWithCallback('getResetThemeEnabled', undefined, 47 cr.sendWithCallback('getResetThemeEnabled', undefined,
29 this.setResetThemeEnabled.bind(this)); 48 this.setResetThemeEnabled.bind(this));
30 49
31 // Set up the change event listener. 50 // Set up the change event listener.
32 cr.addWebUIListener('reset-theme-enabled-changed', 51 cr.addWebUIListener('reset-theme-enabled-changed',
33 this.setResetThemeEnabled.bind(this)); 52 this.setResetThemeEnabled.bind(this));
34 }, 53 },
35 54
36 properties: { 55 homepage_is_newtabpageChanged: function(newValue) {
37 /** 56 this.isNewTabPageString = newValue ? 't' : 'f';
38 * Preferences state. 57 },
39 */ 58
40 prefs: { 59 isNewTabPageStringChanged: function(newValue) {
41 type: Object, 60 this.set('prefs.homepage_is_newtabpage.value',
42 notify: true, 61 this.isNewTabPageString == 't' ? true : false);
43 },
44 }, 62 },
Dan Beam 2015/09/15 23:44:44 ^ make these private
dschuyler 2015/09/16 00:14:28 Done.
45 63
46 setResetThemeEnabled: function(enabled) { 64 setResetThemeEnabled: function(enabled) {
47 this.$.resetTheme.disabled = !enabled; 65 this.$.resetTheme.disabled = !enabled;
48 }, 66 },
49 67
50 /** @private */ 68 /** @private */
51 openThemesGallery_: function() { 69 openThemesGallery_: function() {
52 window.open(loadTimeData.getString('themesGalleryUrl')); 70 window.open(loadTimeData.getString('themesGalleryUrl'));
53 }, 71 },
54 72
55 /** @private */ 73 /** @private */
56 resetTheme_: function() { 74 resetTheme_: function() {
57 chrome.send('resetTheme'); 75 chrome.send('resetTheme');
58 }, 76 },
59 }); 77 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698