Issue 1345903002: Revert of Parallel cache - preliminary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1345903002: Revert of Parallel cache - preliminary (Closed)

Created:
5 years, 3 months ago by herb_g

Modified:
5 years, 3 months ago

Reviewers:
mtklein, mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Parallel cache - preliminary (patchset #24 id:460001 of https://codereview.chromium.org/1264103003/ ) Reason for revert: Breaks DrMemory in the chrome roll. Original issue's description: > Parallel cache. > > TBR=reed@google.com > > BUG=skia:1330, 528560 > > Committed: https://skia.googlesource.com/skia/+/6f2a486040cb25465990196c229feb47e668e87f > > Committed: https://skia.googlesource.com/skia/+/bf2988833e5a36c6b430da6fdd2cfebd0015adec > > Committed: https://skia.googlesource.com/skia/+/014ffdb01ea5317614a1569efc30c50f06434222 TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:1330, 528560 Committed: https://skia.googlesource.com/skia/+/cd7f03597475ea423aa819bdae03996b26874dd5

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+208 lines, -352 lines)			Patch
M	include/core/SkAtomics.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	include/ports/SkAtomics_atomic.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	include/ports/SkAtomics_std.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	include/ports/SkAtomics_sync.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/core/SkDraw.cpp	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/core/SkGlyph.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/core/SkGlyphCache.h	View	5 chunks	+17 lines, -50 lines	0 comments	Download
M	src/core/SkGlyphCache.cpp	View	18 chunks	+172 lines, -253 lines	0 comments	Download
M	src/core/SkGlyphCache_Globals.h	View	3 chunks	+13 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345903002/1

5 years, 3 months ago (2015-09-15 22:15:33 UTC) #2

commit-bot: I haz the power

5 years, 3 months ago (2015-09-15 22:15:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cd7f03597475ea423aa819bdae03996b26874dd5

Expand Messages | Collapse Messages