Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.cc

Issue 13459008: Support options page handling into ComponentExtensionManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit: remove unused variable. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc ('K') | « chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc ('k') | chromeos/ime/component_extension_ime_manager.h » ('j') | chromeos/ime/component_extension_ime_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/input_method_manager_impl.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
index 0aab684ef53c7f1d90e98c8f8b29ab7a740011fc..36370a5faeb5e90049bcf70992c4d294e75beb07 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
@@ -379,8 +379,9 @@ void InputMethodManagerImpl::AddInputMethodExtension(
}
const std::string layout = layouts.empty() ? "" : layouts[0];
+ // TODO(nona): Support options page for normal extension ime.
satorux1 2013/04/15 04:16:08 please add a bug URL
Seigo Nonaka 2013/04/15 04:25:53 Done.
extra_input_methods_[id] =
- InputMethodDescriptor(id, name, layout, language, true);
+ InputMethodDescriptor(id, name, layout, language, "", true);
if (!Contains(filtered_extension_imes_, id) &&
!ComponentExtensionIMEManager::IsComponentExtensionIMEId(id)) {
if (!Contains(active_input_method_ids_, id)) {
« chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc ('K') | « chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc ('k') | chromeos/ime/component_extension_ime_manager.h » ('j') | chromeos/ime/component_extension_ime_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698