third_party/webrtc_overrides/DEPS - Issue 1345873004: Add third_party/webrtc_overrides.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/webrtc_overrides/DEPS

Issue 1345873004: Add third_party/webrtc_overrides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Some comment fixes. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 '+base',	2 '+base',

	3 '+net/base',

3 '+third_party/webrtc',	4 '+third_party/webrtc',
	jam 2015/09/22 15:49:38 is this a circular dependency? i.e. i think third_ is this a circular dependency? i.e. i think third_party/webrtc will also depend on webrtc_overrides right? Henrik Grunell 2015/09/22 18:57:22 Well, the overrides replaces the corresponding fil Show quoted text On 2015/09/22 15:49:38, jam wrote: > is this a circular dependency? i.e. i think third_party/webrtc will also depend > on webrtc_overrides right? Well, the overrides replaces the corresponding files in third_party/webrtc, so it "depends" on the overrides in that sense. Otherwise it wouldn't be overrides, right? Fwiw there's no DEPS file in third_party/webrtc and there's no explicit including from webrtc_overrides in third_party/webrtc, only include order magic. tommi (sloooow) - chröme 2015/09/28 15:40:03 Not really. There's no explicit dependency from w Show quoted text On 2015/09/22 15:49:38, jam wrote: > is this a circular dependency? i.e. i think third_party/webrtc will also depend > on webrtc_overrides right? Not really. There's no explicit dependency from webrtc over to webrtc_overrides. The webrtc_overrides folder is just a regular overrides folder where we inject Chromium implementations into third party libraries via files (essentially a form of an interface if you will) that the library defines. See e.g. this original file (literally a "random" example): https://code.google.com/p/chromium/codesearch#chromium/src/third_party/cachei... overridden here for Chromium: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/cachei...
4 ]	5 ]

OLD	NEW

« no previous file with comments | « no previous file | third_party/webrtc_overrides/OWNERS » ('j') | no next file with comments »