Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1345783002: Updates mojo:view_manager -> mojo:mus (Closed)

Created:
5 years, 3 months ago by sky
Modified:
5 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates mojo:view_manager -> mojo:mus This is necessary as the build target names were changed. BUG=none TEST=none R=fsamuel@chromium.org TBR=fsamuel@chromium.org Committed: https://crrev.com/c696b076941029dc5699c824c3937239bffae555 Cr-Commit-Position: refs/heads/master@{#348972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M components/html_viewer/html_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/view_tree_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/view_tree_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/frame_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/core_services_initialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/surface_binding.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/desktop_ui/browser_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/data/apptests View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
sky
5 years, 3 months ago (2015-09-15 18:28:57 UTC) #1
Fady Samuel
lgtm
5 years, 3 months ago (2015-09-15 18:30:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345783002/1
5 years, 3 months ago (2015-09-15 18:32:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 20:08:56 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c696b076941029dc5699c824c3937239bffae555 Cr-Commit-Position: refs/heads/master@{#348972}
5 years, 3 months ago (2015-09-15 20:09:25 UTC) #6
chromium-reviews
Seems below changes are necessary to make mandoline work. diff --git a/mandoline/services/core_services/application_delegate_factory_notandroid.cc b/mandoline/services/core_services/application_delegate_factory_notandroid.cc index 64a0b2d..3b98097 ...
5 years, 3 months ago (2015-09-15 20:32:34 UTC) #7
sky
Agreed. Can you upload a patch to that effect? On Tue, Sep 15, 2015 at ...
5 years, 3 months ago (2015-09-15 20:49:44 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:48:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c696b076941029dc5699c824c3937239bffae555
Cr-Commit-Position: refs/heads/master@{#348972}

Powered by Google App Engine
This is Rietveld 408576698