|
|
Created:
5 years, 3 months ago by Mostyn Bramley-Moore Modified:
5 years, 3 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmove zip template to a non-android-specific .gni file
The zip template really isn't android-specific, let's move it to its
own .gni file which doesn't assert(is_android).
Committed: https://crrev.com/3dba3175c9f137742ddb10dbe9a10a5417186402
Cr-Commit-Position: refs/heads/master@{#349016}
Patch Set 1 #Patch Set 2 : move zip.gni up one directory #
Messages
Total messages: 23 (8 generated)
mostynb@opera.com changed reviewers: + agrieve@chromium.org
@agrieve: PTAL at this minor adjustment.
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345733002/1
agrieve@chromium.org changed reviewers: + dpranke@google.com - agrieve@chromium.org
On 2015/09/15 17:07:40, commit-bot: I haz the power wrote: > Dry run: CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1345733002/1 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1345733002/1 Punting to dpranke - as I'm not sure if there's a better place for non-android-specific rules (e.g. move this and its script into //build?)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Is there a plan to use the zip template from any other files? If not, I'm not sure that there's much of an advantage to moving it into its own file.
On 2015/09/15 20:18:29, Dirk Pranke wrote: > Is there a plan to use the zip template from any other files? If not, I'm not > sure that there's much of an advantage to moving it into its own file. I'm using it from a downstream linux project. It might be useful in chromium itself in the future, but if not I don't think this patch does any harm in the meantime.
On 2015/09/15 20:26:06, Mostyn Bramley-Moore wrote: > On 2015/09/15 20:18:29, Dirk Pranke wrote: > > Is there a plan to use the zip template from any other files? If not, I'm not > > sure that there's much of an advantage to moving it into its own file. > > I'm using it from a downstream linux project. It might be useful in chromium > itself in the future, but if not I don't think this patch does any harm in the > meantime. Okay, if there's another use for it. We don't really have a place for generic templates yet, but build/config/android is probably not right, so maybe move it to build/config ?
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345733002/20001
On 2015/09/15 20:48:24, Dirk Pranke wrote: > Okay, if there's another use for it. > > We don't really have a place for generic templates yet, but build/config/android > is probably not right, so maybe move it to build/config ? Done in patch set 2.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345733002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3dba3175c9f137742ddb10dbe9a10a5417186402 Cr-Commit-Position: refs/heads/master@{#349016}
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3dba3175c9f137742ddb10dbe9a10a5417186402 Cr-Commit-Position: refs/heads/master@{#349016} |