Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1345733002: move zip template to a non-android-specific .gni file (Closed)

Created:
5 years, 3 months ago by Mostyn Bramley-Moore
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

move zip template to a non-android-specific .gni file The zip template really isn't android-specific, let's move it to its own .gni file which doesn't assert(is_android). Committed: https://crrev.com/3dba3175c9f137742ddb10dbe9a10a5417186402 Cr-Commit-Position: refs/heads/master@{#349016}

Patch Set 1 #

Patch Set 2 : move zip.gni up one directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -40 lines) Patch
M build/config/android/internal_rules.gni View 1 2 chunks +1 line, -40 lines 0 comments Download
A build/config/zip.gni View 1 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
Mostyn Bramley-Moore
@agrieve: PTAL at this minor adjustment.
5 years, 3 months ago (2015-09-15 14:57:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345733002/1
5 years, 3 months ago (2015-09-15 17:07:40 UTC) #4
agrieve
On 2015/09/15 17:07:40, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 3 months ago (2015-09-15 17:20:33 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 18:14:58 UTC) #8
Dirk Pranke
Is there a plan to use the zip template from any other files? If not, ...
5 years, 3 months ago (2015-09-15 20:18:29 UTC) #9
Mostyn Bramley-Moore
On 2015/09/15 20:18:29, Dirk Pranke wrote: > Is there a plan to use the zip ...
5 years, 3 months ago (2015-09-15 20:26:06 UTC) #10
Dirk Pranke
On 2015/09/15 20:26:06, Mostyn Bramley-Moore wrote: > On 2015/09/15 20:18:29, Dirk Pranke wrote: > > ...
5 years, 3 months ago (2015-09-15 20:48:24 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345733002/20001
5 years, 3 months ago (2015-09-15 21:08:45 UTC) #13
Mostyn Bramley-Moore
On 2015/09/15 20:48:24, Dirk Pranke wrote: > Okay, if there's another use for it. > ...
5 years, 3 months ago (2015-09-15 21:08:45 UTC) #14
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-15 21:18:03 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 22:08:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345733002/20001
5 years, 3 months ago (2015-09-15 22:08:58 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 22:16:13 UTC) #21
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3dba3175c9f137742ddb10dbe9a10a5417186402 Cr-Commit-Position: refs/heads/master@{#349016}
5 years, 3 months ago (2015-09-15 22:16:44 UTC) #22
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:50:36 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3dba3175c9f137742ddb10dbe9a10a5417186402
Cr-Commit-Position: refs/heads/master@{#349016}

Powered by Google App Engine
This is Rietveld 408576698