Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1345713002: Revert of Convert webkit_unit_tests to run exclusively on Swarming (Closed)

Created:
5 years, 3 months ago by kochi
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel, joelo
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@swarm_wtf_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert webkit_unit_tests to run exclusively on Swarming (patchset #2 id:20001 of https://codereview.chromium.org/1341903002/ ) Reason for revert: This seems causing isolated test problem: https://code.google.com/p/chromium/issues/detail?id=531819 Original issue's description: > Convert webkit_unit_tests to run exclusively on Swarming > > 0 configs already ran on Swarming > 43 used to run locally and were converted: > - chromium.fyi.json: ClangToTLinux tester > - chromium.fyi.json: ClangToTLinuxASan tester > - chromium.fyi.json: ClangToTMac tester > - chromium.fyi.json: ClangToTMacASan tester > - chromium.fyi.json: ClangToTWin tester > - chromium.fyi.json: ClangToTWin(dbg) tester > - chromium.fyi.json: ClangToTWin(dll) tester > - chromium.fyi.json: ClangToTWin64 tester > - chromium.fyi.json: ClangToTWin64(dbg) tester > - chromium.fyi.json: ClangToTWin64(dll) tester > - chromium.fyi.json: CrWinClang tester > - chromium.fyi.json: CrWinClang(dbg) tester > - chromium.fyi.json: CrWinClang(shared) tester > - chromium.fyi.json: CrWinClang64 tester > - chromium.fyi.json: CrWinClang64(dbg) tester > - chromium.fyi.json: CrWinClang64(dll) tester > - chromium.fyi.json: CrWinClangLLD tester > - chromium.webkit.json: WebKit Linux > - chromium.webkit.json: WebKit Linux (dbg) > - chromium.webkit.json: WebKit Linux 32 > - chromium.webkit.json: WebKit Linux Leak > - chromium.webkit.json: WebKit Linux Oilpan > - chromium.webkit.json: WebKit Linux Oilpan (dbg) > - chromium.webkit.json: WebKit Linux Oilpan Leak > - chromium.webkit.json: WebKit Linux Trusty > - chromium.webkit.json: WebKit Mac Oilpan > - chromium.webkit.json: WebKit Mac Oilpan (dbg) > - chromium.webkit.json: WebKit Mac10.10 > - chromium.webkit.json: WebKit Mac10.6 > - chromium.webkit.json: WebKit Mac10.6 (dbg) > - chromium.webkit.json: WebKit Mac10.7 > - chromium.webkit.json: WebKit Mac10.7 (dbg) > - chromium.webkit.json: WebKit Mac10.8 > - chromium.webkit.json: WebKit Mac10.9 > - chromium.webkit.json: WebKit Mac10.9 (retina) > - chromium.webkit.json: WebKit Win Oilpan > - chromium.webkit.json: WebKit Win Oilpan (dbg) > - chromium.webkit.json: WebKit Win x64 Builder > - chromium.webkit.json: WebKit Win x64 Builder (dbg) > - chromium.webkit.json: WebKit Win10 > - chromium.webkit.json: WebKit Win7 > - chromium.webkit.json: WebKit Win7 (dbg) > - chromium.webkit.json: WebKit XP > > Ran: > ./manage.py --convert webkit_unit_tests > > R=maruel@chromium.org,dpranke@chromium.org > BUG=98637, 524758 > > Committed: https://crrev.com/40eeb7ab654466217dcbd444bd7d853cba8b3348 > Cr-Commit-Position: refs/heads/master@{#348834} TBR=dpranke@chromium.org,maruel@chromium.org,joelo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637, 524758 Committed: https://crrev.com/52fbb354ec21e2ab7952a448f294d10007338e64 Cr-Commit-Position: refs/heads/master@{#348841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -130 lines) Patch
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.fyi.json View 17 chunks +0 lines, -51 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 26 chunks +0 lines, -78 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kochi
Created Revert of Convert webkit_unit_tests to run exclusively on Swarming
5 years, 3 months ago (2015-09-15 06:26:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345713002/1
5 years, 3 months ago (2015-09-15 06:26:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 06:27:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/52fbb354ec21e2ab7952a448f294d10007338e64 Cr-Commit-Position: refs/heads/master@{#348841}
5 years, 3 months ago (2015-09-15 06:27:49 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:42:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52fbb354ec21e2ab7952a448f294d10007338e64
Cr-Commit-Position: refs/heads/master@{#348841}

Powered by Google App Engine
This is Rietveld 408576698