Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1345703002: ozone: Remove the "drm" software composited platform (Closed)

Created:
5 years, 3 months ago by spang
Modified:
5 years, 3 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Remove the "drm" software composited platform This is a software-only platform that was used early in the process of bringing up the Chrome OS ozone/freon (no X11) build. It's time to remove it because it now requires not only scary flags to get it going, but also a patch (https://codereview.chromium.org/1216303004/). If we need a build with software rasterization let's use vgem+swrast like our VMtests do. BUG=531814 TEST=link still works fine with platform=gbm Committed: https://crrev.com/d0620b8a4b025b5d808644068d155e07dcaa0276 Cr-Commit-Position: refs/heads/master@{#349012}

Patch Set 1 #

Patch Set 2 : rm more bits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -967 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download
M ui/ozone/ozone.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/BUILD.gn View 1 4 chunks +57 lines, -97 lines 0 comments Download
D ui/ozone/platform/drm/common/client_native_pixmap_factory_drm.h View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/ozone/platform/drm/common/client_native_pixmap_factory_drm.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/ozone/platform/drm/drm.gypi View 1 chunk +0 lines, -155 lines 0 comments Download
M ui/ozone/platform/drm/gbm.gypi View 1 4 chunks +103 lines, -2 lines 0 comments Download
D ui/ozone/platform/drm/gpu/drm_surface.h View 1 1 chunk +0 lines, -67 lines 0 comments Download
D ui/ozone/platform/drm/gpu/drm_surface.cc View 1 1 chunk +0 lines, -120 lines 0 comments Download
D ui/ozone/platform/drm/gpu/drm_surface_factory.h View 1 1 chunk +0 lines, -41 lines 0 comments Download
D ui/ozone/platform/drm/gpu/drm_surface_factory.cc View 1 1 chunk +0 lines, -39 lines 0 comments Download
D ui/ozone/platform/drm/gpu/drm_surface_unittest.cc View 1 1 chunk +0 lines, -197 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
D ui/ozone/platform/drm/ozone_platform_drm.h View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/ozone/platform/drm/ozone_platform_drm.cc View 1 chunk +0 lines, -171 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
spang
5 years, 3 months ago (2015-09-15 04:28:32 UTC) #2
dnicoara
lgtm What's the plan for some of the other DRM/software only files (DrmSurface, etc...)? Are ...
5 years, 3 months ago (2015-09-15 05:12:59 UTC) #3
spang
On 2015/09/15 05:12:59, dnicoara wrote: > lgtm > > What's the plan for some of ...
5 years, 3 months ago (2015-09-15 05:32:17 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345703002/20001
5 years, 3 months ago (2015-09-15 05:42:13 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 07:34:36 UTC) #8
spang
+agrieve for build/
5 years, 3 months ago (2015-09-15 15:41:20 UTC) #10
dnicoara
lgtm
5 years, 3 months ago (2015-09-15 15:49:11 UTC) #11
alexst (slow to review)
lgtm
5 years, 3 months ago (2015-09-15 16:12:33 UTC) #12
agrieve
On 2015/09/15 16:12:33, alexst wrote: > lgtm build lgtm
5 years, 3 months ago (2015-09-15 16:59:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345703002/20001
5 years, 3 months ago (2015-09-15 17:13:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345703002/20001
5 years, 3 months ago (2015-09-15 21:49:27 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 22:00:12 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d0620b8a4b025b5d808644068d155e07dcaa0276 Cr-Commit-Position: refs/heads/master@{#349012}
5 years, 3 months ago (2015-09-15 22:00:50 UTC) #20
spang
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1350473002/ by spang@chromium.org. ...
5 years, 3 months ago (2015-09-15 23:40:22 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:50:27 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0620b8a4b025b5d808644068d155e07dcaa0276
Cr-Commit-Position: refs/heads/master@{#349012}

Powered by Google App Engine
This is Rietveld 408576698