Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1345663004: small tweaks to cmake_build (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

small tweaks to cmake_build - streamline how we define $here - only make `cmake` when bootstrapping; it's a little less to build BUG=skia:4269 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/de5973b05be6ecc80309cded8541f9c305135d15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M cmake/cmake_build View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
5 years, 3 months ago (2015-09-15 17:01:41 UTC) #2
borenet
LGTM
5 years, 3 months ago (2015-09-15 17:03:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345663004/1
5 years, 3 months ago (2015-09-15 17:03:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345663004/1
5 years, 3 months ago (2015-09-15 17:10:20 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 17:17:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/de5973b05be6ecc80309cded8541f9c305135d15

Powered by Google App Engine
This is Rietveld 408576698