Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1345633002: ipc: Move //crypto dependency into a Windows-only file. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam, Sergey Ulanov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Move //crypto dependency into a Windows-only file. //ipc only depends on //crypto on Windows. GN checks #includes against dependencies, but isn't able to evaluate preprocessor conditionals. This causes problems. In https://codereview.chromium.org/1321253011/, the dependency was moved into several other files, but this also changed the public interface of BrokerableAttachment::AttachmentId in an undesirable manner. Instead, this CL makes the new file brokerable_attachment_win.cc to include the the crypto dependency. BUG= Committed: https://crrev.com/a5085cda2c9f25c34eec39759f67d79e3bfe7d2e Cr-Commit-Position: refs/heads/master@{#348923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -28 lines) Patch
M ipc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/brokerable_attachment.h View 2 chunks +10 lines, -0 lines 0 comments Download
M ipc/brokerable_attachment.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A ipc/brokerable_attachment_win.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M ipc/handle_attachment_win.cc View 1 chunk +1 line, -18 lines 0 comments Download
M ipc/ipc.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_reader_unittest.cc View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345633002/1
5 years, 3 months ago (2015-09-14 23:08:06 UTC) #2
erikchen
tsepez: Please review.
5 years, 3 months ago (2015-09-14 23:54:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 00:35:07 UTC) #6
Tom Sepez
lgtm
5 years, 3 months ago (2015-09-15 17:16:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345633002/1
5 years, 3 months ago (2015-09-15 17:19:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 17:26:36 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a5085cda2c9f25c34eec39759f67d79e3bfe7d2e Cr-Commit-Position: refs/heads/master@{#348923}
5 years, 3 months ago (2015-09-15 17:27:12 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:46:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5085cda2c9f25c34eec39759f67d79e3bfe7d2e
Cr-Commit-Position: refs/heads/master@{#348923}

Powered by Google App Engine
This is Rietveld 408576698